<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 7, 2013, at 10:08 AM, Shuxin Yang <<a href="mailto:shuxin.llvm@gmail.com">shuxin.llvm@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Please be specific! What are the
problematic styles?<br></div></div></blockquote><div><br></div><div>Chandler's first email in this thread (the really long one!) had a lot of good stylistic suggestions. <a href="http://llvm.org/docs/CodingStandards.html">http://llvm.org/docs/CodingStandards.html</a> has the coding standards guide, and many of the things he pointed out are from it. If you lost that email, I can resend it to you.</div><br><blockquote type="cite"><div bgcolor="#FFFFFF" text="#000000"><div class="moz-cite-prefix">
Your previous mail about this issue full of technical mistake
about population count. <br>
I have to ignore it. <br>
<br>
On 1/7/13 12:42 AM, Chandler Carruth wrote:<br>
</div>
<blockquote cite="mid:CAGCO0KjN0oDgcU_1Yo+TvMRZtrE-X4B6of6_CuHkdxvZMaNmgw@mail.gmail.com" type="cite">
<div dir="ltr">
<div class="gmail_extra">On Fri, Dec 7, 2012 at 6:35 PM,
Chandler Carruth <span dir="ltr"><<a moz-do-not-send="true" href="mailto:chandlerc@google.com" target="_blank" class="cremed">chandlerc@google.com</a>></span>
wrote:<br>
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">
<div> </div>
<blockquote class="gmail_quote" style="margin:0px 0px
0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000"> Some "style"
is the combination of different reviewer's tastes.
Some reviewers' taste are just opposite to you
personal opinions.<br>
</div>
</blockquote>
<div><br>
</div>
</div>
<div>Within the LLVM project, style is part of code
review. My comments below about the style issues with
your code are code review that needs to be addressed,
even if they don't seem like important style issues to
you.</div>
</blockquote>
</div>
<br>
</div>
<div class="gmail_extra" style="">Shuxin, I hate to dig this
back up, but the style of this code really does need to be
addressed. I'm having to make changes to this code as I
refactor other parts of LLVM, and it is substantially harder
to read, modify, and generally maintain. That is why we have
code review even for style and design, and why it is so
important that these review comments are addressed.</div>
<div class="gmail_extra" style=""><br>
</div>
<div class="gmail_extra" style="">Please prioritize resolving
these issues with this code. It has been in the tree in a form
that is well below the expected code quality of LLVM for a
month now. I think that is too long.</div>
</div>
</blockquote>
<br>
</div>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></body></html>