<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>llvm-gcc-4.2 complains about it. The constructor is empty anyway.</div><div><br>Sent from my iPad</div><div><br>On Jan 4, 2013, at 4:44 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><div class="gmail_default" style="">On Fri, Jan 4, 2013 at 4:21 PM, Alex Rosenberg <span dir="ltr"><<a href="mailto:alexr@leftfield.org" target="_blank" class="cremed">alexr@leftfield.org</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: alexr<br>
Date: Fri Jan 4 18:21:12 2013<br>
New Revision: 171567<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=171567&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=171567&view=rev</a><br>
Log:<br>
Fix warnings from llvm-gcc as seen on darwin10 (10.6).<br></blockquote><div><br></div><div style="">Is this really worthwhile? Calling the base constructor happens implicitly as the standard requires it...</div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/include/llvm/ADT/DenseMap.h<br>
<br>
Modified: llvm/trunk/include/llvm/ADT/DenseMap.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=171567&r1=171566&r2=171567&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ADT/DenseMap.h?rev=171567&r1=171566&r2=171567&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/include/llvm/ADT/DenseMap.h (original)<br>
+++ llvm/trunk/include/llvm/ADT/DenseMap.h Fri Jan 4 18:21:12 2013<br>
@@ -531,13 +531,13 @@<br>
init(NumInitBuckets);<br>
}<br>
<br>
- DenseMap(const DenseMap &other) {<br>
+ DenseMap(const DenseMap &other) : BaseT() {<br>
init(0);<br>
copyFrom(other);<br>
}<br>
<br>
#if LLVM_HAS_RVALUE_REFERENCES<br>
- DenseMap(DenseMap &&other) {<br>
+ DenseMap(DenseMap &&other) : BaseT() {<br>
init(0);<br>
swap(other);<br>
}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>
</div></blockquote></body></html>