What were the failure signatures? My change was basically reverting a change I made last week so I'm shocked that it caused any failures.<br><br><div class="gmail_quote">On Thu, Jan 3, 2013 at 12:20 AM, Michael Gottesman <span dir="ltr"><<a href="mailto:mgottesman@apple.com" target="_blank">mgottesman@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">This commit breaks a bunch of tests on smooshlab clang-x86_64-darwin12-RA. Specifically:<div>
<pre style="font-family:'Courier New',courier,monotype"><span>Clang :: Analysis/outofbound-notwork.c
Clang :: Analysis/string-fail.c
Clang :: CXX/basic/basic.lookup/basic.lookup.qual/p6-0x.cpp
Clang :: CXX/basic/basic.lookup/basic.lookup.unqual/p15.cpp
Clang :: CXX/dcl.dcl/dcl.spec/dcl.fct.spec/p4.cpp
Clang :: CXX/dcl.dcl/dcl.spec/dcl.stc/p10.cpp
Clang :: CXX/temp/temp.param/p14.cpp
Clang :: CXX/temp/temp.res/temp.dep.res/temp.point/p1.cpp
Clang :: CodeGen/2009-02-13-zerosize-union-field-ppc.c
Clang :: CodeGen/blocks-2.c
Clang :: CodeGen/libcalls-d.c
Clang :: CodeGen/libcalls-ld.c
Clang :: CodeGenCXX/conversion-function.cpp
Clang :: CodeGenCXX/debug-info-limit-type.cpp
Clang :: CodeGenCXX/inheriting-constructor.cpp
Clang :: FixIt/fixit-errors.c
Clang :: FixIt/fixit-pmem.cpp
Clang :: Modules/namespaces.cpp
Clang :: PCH/changed-files.c
Clang :: PCH/pr4489.c
Clang :: PCH/source-manager-stack.c
Clang :: Parser/cxx-ambig-decl-expr-xfail.cpp
Clang :: SemaCXX/switch-implicit-fallthrough-cxx98.cpp
Clang :: SemaTemplate/<a href="http://instantiate-function-1.mm" target="_blank">instantiate-function-1.mm</a></span></pre><div>I would normally ask for a fix first but this broke a lot of tests. Reverted in r171466.</div>
</div><div><br></div><div>Michael</div><div><br><div><div>On Jan 3, 2013, at 8:40 AM, Craig Topper <<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>> wrote:</div><br><blockquote type="cite">
Author: ctopper<br>Date: Thu Jan 3 00:40:20 2013<br>New Revision: 171461<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=171461&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=171461&view=rev</a><br>
Log:<br>Mark DIV/IDIV instructions hasSideEffects=1 because they can trap when dividing by 0. This is needed to keep early if conversion from moving them across basic blocks.<br><br>Modified:<br> llvm/trunk/lib/Target/X86/X86InstrArithmetic.td<br>
llvm/trunk/test/CodeGen/X86/early-ifcvt.ll<br><br>Modified: llvm/trunk/lib/Target/X86/X86InstrArithmetic.td<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrArithmetic.td?rev=171461&r1=171460&r2=171461&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrArithmetic.td?rev=171461&r1=171460&r2=171461&view=diff</a><br>
==============================================================================<br>--- llvm/trunk/lib/Target/X86/X86InstrArithmetic.td (original)<br>+++ llvm/trunk/lib/Target/X86/X86InstrArithmetic.td Thu Jan 3 00:40:20 2013<br>
@@ -266,7 +266,7 @@<br><br><br> // unsigned division/remainder<br>-let hasSideEffects = 0 in {<br>+let hasSideEffects = 1 in { // so that we don't speculatively execute<br> let Defs = [AL,EFLAGS,AX], Uses = [AX] in<br>
def DIV8r : I<0xF6, MRM6r, (outs), (ins GR8:$src), // AX/r8 = AL,AH<br> "div{b}\t$src", [], IIC_DIV8_REG>;<br><br>Modified: llvm/trunk/test/CodeGen/X86/early-ifcvt.ll<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/early-ifcvt.ll?rev=171461&r1=171460&r2=171461&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/early-ifcvt.ll?rev=171461&r1=171460&r2=171461&view=diff</a><br>
==============================================================================<br>--- llvm/trunk/test/CodeGen/X86/early-ifcvt.ll (original)<br>+++ llvm/trunk/test/CodeGen/X86/early-ifcvt.ll Thu Jan 3 00:40:20 2013<br>@@ -142,3 +142,35 @@<br>
}<br><br> declare void @BZ2_bz__AssertH__fail()<br>+<br>+<br>+; Make sure we don't speculate on div/idiv instructions<br>+; CHECK: test_idiv<br>+; CHECK-NOT: cmov<br>+define i32 @test_idiv(i32 %a, i32 %b) nounwind uwtable readnone ssp {<br>
+ %1 = icmp eq i32 %b, 0<br>+ br i1 %1, label %4, label %2<br>+<br>+; <label>:2 ; preds = %0<br>+ %3 = sdiv i32 %a, %b<br>+ br label %4<br>+<br>+; <label>:4 ; preds = %0, %2<br>
+ %5 = phi i32 [ %3, %2 ], [ %a, %0 ]<br>+ ret i32 %5<br>+}<br>+<br>+; CHECK: test_div<br>+; CHECK-NOT: cmov<br>+define i32 @test_div(i32 %a, i32 %b) nounwind uwtable readnone ssp {<br>+ %1 = icmp eq i32 %b, 0<br>+ br i1 %1, label %4, label %2<br>
+<br>+; <label>:2 ; preds = %0<br>+ %3 = udiv i32 %a, %b<br>+ br label %4<br>+<br>+; <label>:4 ; preds = %0, %2<br>+ %5 = phi i32 [ %3, %2 ], [ %a, %0 ]<br>
+ ret i32 %5<br>+}<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></blockquote></div><br><br clear="all"><br>-- <br>~Craig