<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr"><div class="gmail_default" style>On Wed, Dec 26, 2012 at 3:22 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank" class="cremed">craig.topper@gmail.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">A lot of the ones I'm fixing right now probably don't have any real functional impact. This particular case is on an instruction with a custom inserter so none of the Machine passes even see this instruction. But with it defaulting to having it side effect, it makes looking through the output to find possibly real broken instructions noisy.</blockquote>
<div><br></div><div style>Ahh, that makes some sense. Thanks for the explanation. (Your other commit messages also started to clue me in that most of these aren't "real" instructions, or were blindingly wrong.)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><br>
<br><div class="gmail_quote">On Wed, Dec 26, 2012 at 3:19 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank" class="cremed">chandlerc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div dir="ltr"><div><div>On Wed, Dec 26, 2012 at 3:08 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank" class="cremed">craig.topper@gmail.com</a>></span> wrote:<br>
</div></div><div class="gmail_extra"><div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ctopper<br>
Date: Wed Dec 26 17:08:12 2012<br>
New Revision: 171122<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=171122&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=171122&view=rev</a><br>
Log:<br>
Add hasSideEffects=0 to some atomic instructions.<br></blockquote><div><br></div></div><div>Is there a test case or something else that can go here? Not sure what the practical impact of this is in the backend... (I'm assume it is substantially different than in the middle end...)</div>
<div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/Target/X86/X86InstrCompiler.td<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86InstrCompiler.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrCompiler.td?rev=171122&r1=171121&r2=171122&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrCompiler.td?rev=171122&r1=171121&r2=171122&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86InstrCompiler.td (original)<br>
+++ llvm/trunk/lib/Target/X86/X86InstrCompiler.td Wed Dec 26 17:08:12 2012<br>
@@ -559,7 +559,7 @@<br>
defm : PSEUDO_ATOMIC_LOAD_BINOP_PATS<"ATOMUMIN", "atomic_load_umin">;<br>
<br>
multiclass PSEUDO_ATOMIC_LOAD_BINOP6432<string mnemonic> {<br>
- let usesCustomInserter = 1, mayLoad = 1, mayStore = 1 in<br>
+ let usesCustomInserter = 1, mayLoad = 1, mayStore = 1, hasSideEffects = 0 in<br>
def #NAME#6432 : I<0, Pseudo, (outs GR32:$dst1, GR32:$dst2),<br>
(ins i64mem:$ptr, GR32:$val1, GR32:$val2),<br>
!strconcat(mnemonic, "6432 PSEUDO!"), []>;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div><br></div></div></div>
</blockquote></div><br><br clear="all"><br></div></div><span class="HOEnZb"><font color="#888888">-- <br>~Craig
</font></span></blockquote></div><br></div></div></div>