<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr"><div class="gmail_default" style><br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Dec 25, 2012 at 11:26 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div class="im">On Tue, Dec 25, 2012 at 11:17 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
</div><div class="gmail_quote"><div class="im"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: kcc<br>
Date: Tue Dec 25 01:17:17 2012<br>
New Revision: 171052<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=171052&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=171052&view=rev</a><br>
Log:<br>
[asan] properly define ASAN_LOW_MEMORY. Due to a mistake it has been always true causing redzone and quarantine sizes to be smaller than it was some time before (and out of sync with the documentation). Also make one test less greedy<br>
</blockquote><div><br></div></div><div>OMG. Changing allocator brings unexpected benefits.</div></div></div></blockquote><div><br></div><div style>OMG indeed. </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div class="gmail_quote"><div><div class="h5"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
compiler-rt/trunk/lib/asan/asan_internal.h<br>
compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc<br>
<br>
Modified: compiler-rt/trunk/lib/asan/asan_internal.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_internal.h?rev=171052&r1=171051&r2=171052&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_internal.h?rev=171052&r1=171051&r2=171052&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/asan/asan_internal.h (original)<br>
+++ compiler-rt/trunk/lib/asan/asan_internal.h Tue Dec 25 01:17:17 2012<br>
@@ -83,9 +83,9 @@<br>
// If set, values like allocator chunk size, as well as defaults for some flags<br>
// will be changed towards less memory overhead.<br>
#ifndef ASAN_LOW_MEMORY<br>
-# ifdef ASAN_ANDROID<br>
+#if SANITIZER_WORDSIZE == 32<br>
# define ASAN_LOW_MEMORY 1<br>
-# else<br>
+#else<br>
# define ASAN_LOW_MEMORY 0<br>
# endif<br>
#endif<br>
<br>
Modified: compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc?rev=171052&r1=171051&r2=171052&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc?rev=171052&r1=171051&r2=171052&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc (original)<br>
+++ compiler-rt/trunk/lib/asan/tests/asan_noinst_test.cc Tue Dec 25 01:17:17 2012<br>
@@ -508,7 +508,7 @@<br>
EXPECT_DEATH(DoLargeMallocForGetFreeBytesTestAndDie(), "double-free");<br>
}<br>
<br>
-static const size_t kManyThreadsMallocSizes[] = {5, 1UL<<10, 1UL<<20, 357};<br>
+static const size_t kManyThreadsMallocSizes[] = {5, 1UL<<10, 1UL<<14, 357};<br>
static const size_t kManyThreadsIterations = 250;<br>
static const size_t kManyThreadsNumThreads =<br>
(SANITIZER_WORDSIZE == 32) ? 40 : 200;<br>
@@ -520,6 +520,8 @@<br>
free(Ident(malloc(kManyThreadsMallocSizes[size_index])));<br>
}<br>
}<br>
+ // Just one large allocation.<br>
+ free(Ident(malloc(1 << 20)));<br>
return 0;<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div><br>
</font></span></div>
</blockquote></div><br></div></div></div>