<div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div dir="ltr"><div class="gmail_default" style>For example, if fails to build this test on my ASan/Win bot:</div><div class="gmail_default" style><a href="http://code.google.com/p/address-sanitizer/source/browse/trunk/win/tests/malloc_right_oob_crash.cpp" class="cremed">http://code.google.com/p/address-sanitizer/source/browse/trunk/win/tests/malloc_right_oob_crash.cpp</a><br>
</div><div class="gmail_default" style>this also fires up an assertion message box which hangs the bot :(</div><div class="gmail_default" style><br></div><div class="gmail_default" style>Is it possible to quick-fix this or revert?</div>
</div><div class="gmail_extra"><br clear="all"><div>Timur Iskhodzhanov, <br>Google Russia <br><br></div>
<br><br><div class="gmail_quote">2012/12/21 Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="font-family:arial,helvetica,sans-serif;font-size:10pt"><div dir="ltr"><div class="gmail_default">Hi Eli,</div><div class="gmail_default"><br></div><div class="gmail_default">I hit this assertion when compiling on Windows with -Xclang -cxx-abi -Xclang microsoft.</div>
<div class="gmail_default">Any ideas how to fix?</div><div class="im"><div class="gmail_default"><br></div><div class="gmail_default">> These fragments aren't even generated when RelaxAll is set</div></div><div class="gmail_default">
Is this true for a WinCOFFStreamer?</div><div class="gmail_default"><br></div><div class="gmail_default">--</div><div class="gmail_default">Thanks,</div><div class="gmail_default">Timur</div></div><span class="HOEnZb"><font color="#888888">
</font></span><div class="gmail_extra"><span class="HOEnZb"><font color="#888888"><br clear="all"><div>Timur Iskhodzhanov, <br>Google Russia <br><br></div></font></span><div><div class="h5">
<br><br><div class="gmail_quote">2012/12/11 Eli Bendersky <span dir="ltr"><<a href="mailto:eliben@google.com" target="_blank">eliben@google.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: eliben<br>
Date: Tue Dec 11 11:16:00 2012<br>
New Revision: 169886<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=169886&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=169886&view=rev</a><br>
Log:<br>
Remove the RelaxAll overrule in MCAssembler::fixupNeedsRelaxation,<br>
because that method is only getting called for MCInstFragment. These<br>
fragments aren't even generated when RelaxAll is set, which is why the<br>
flag reference here is superfluous. Removing it simplifies the code<br>
with no harmful effects.<br>
<br>
An assertion is added higher up to make sure this path is never<br>
reached.<br>
<br>
Modified:<br>
llvm/trunk/lib/MC/MCAssembler.cpp<br>
<br>
Modified: llvm/trunk/lib/MC/MCAssembler.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAssembler.cpp?rev=169886&r1=169885&r2=169886&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAssembler.cpp?rev=169886&r1=169885&r2=169886&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/MC/MCAssembler.cpp (original)<br>
+++ llvm/trunk/lib/MC/MCAssembler.cpp Tue Dec 11 11:16:00 2012<br>
@@ -657,9 +657,6 @@<br>
bool MCAssembler::fixupNeedsRelaxation(const MCFixup &Fixup,<br>
const MCInstFragment *DF,<br>
const MCAsmLayout &Layout) const {<br>
- if (getRelaxAll())<br>
- return true;<br>
-<br>
// If we cannot resolve the fixup value, it requires relaxation.<br>
MCValue Target;<br>
uint64_t Value;<br>
@@ -780,6 +777,8 @@<br>
default:<br>
break;<br>
case MCFragment::FT_Inst:<br>
+ assert(!getRelaxAll() &&<br>
+ "Did not expect a MCInstFragment in RelaxAll mode");<br>
RelaxedFrag = relaxInstruction(Layout, *cast<MCInstFragment>(I));<br>
break;<br>
case MCFragment::FT_Dwarf:<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div></div>
</blockquote></div><br></div></div>