<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Dec 19, 2012, at 1:10 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr"><div class="gmail_default" style="">On Wed, Dec 19, 2012 at 1:04 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank" class="cremed">gribozavr@gmail.com</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto;"><div class="im">On Wed, Dec 19, 2012 at 11:02 PM, Jakob Stoklund Olesen <<a href="mailto:stoklund@2pi.dk" class="cremed">stoklund@2pi.dk</a>> wrote:<br>
><br>
> On Dec 19, 2012, at 11:01 AM, Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com" class="cremed">gribozavr@gmail.com</a>> wrote:<br>
><br>
>> On Tue, Aug 21, 2012 at 12:39 AM, Jakob Stoklund Olesen <<a href="mailto:stoklund@2pi.dk" class="cremed">stoklund@2pi.dk</a>> wrote:<br>
>>> ++MBBI;<br>
>>> if (MBBI == MF->end()) {<br>
>>> report("MBB conditionally falls through out of function!", MBB);<br>
>>> - } if (MBB->succ_size() != 2) {<br>
>>> + } if (MBB->succ_size() == 1) {<br>
>><br>
>> Hello Jakob,<br>
>><br>
>> Sorry to comment on an old commit, but '} if (...' looks suspicious --<br>
>> 'else' is probably missing. I have just fixed two bugs of this kind<br>
>> in Clang, found by grep '} if'.<br>
><br>
> Yikes, that does indeed look like a missing else.<br>
><br>
> Please go ahead and fix it.<br>
<br>
</div>OK to commit without a testcase?</blockquote><div><br></div><div style="">I'd like a testcase. =]</div></div></div></div></div></blockquote><div><br></div><div>What are you proposing?</div></div><br><div>/jakob</div></body></html>