<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div dir="ltr">On Mon, Dec 17, 2012 at 9:59 AM, Tim Northover <span dir="ltr"><<a href="mailto:Tim.Northover@arm.com" target="_blank" class="cremed">Tim.Northover@arm.com</a>></span> wrote:<br>
<div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: tnorthover<br>
Date: Mon Dec 17 11:59:35 2012<br>
New Revision: 170350<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=170350&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=170350&view=rev</a><br>
Log:<br>
Query section for whether it should be executable.<br></blockquote><div><br></div><div style>While your next commit probably exercises this, is it possible to test it independently? Just curious.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Modified:<br>
    llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp<br>
<br>
Modified: llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp?rev=170350&r1=170349&r2=170350&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp?rev=170350&r1=170349&r2=170350&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp (original)<br>
+++ llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyld.cpp Mon Dec 17 11:59:35 2012<br>
@@ -107,20 +107,18 @@<br>
           SymType == object::SymbolRef::ST_Unknown) {<br>
         uint64_t FileOffset;<br>
         StringRef SectionData;<br>
+        bool IsCode;<br>
         section_iterator si = obj->end_sections();<br>
         Check(i->getFileOffset(FileOffset));<br>
         Check(i->getSection(si));<br>
         if (si == obj->end_sections()) continue;<br>
         Check(si->getContents(SectionData));<br>
+        Check(si->isText(IsCode));<br>
         const uint8_t* SymPtr = (const uint8_t*)InputBuffer->getBufferStart() +<br>
                                 (uintptr_t)FileOffset;<br>
         uintptr_t SectOffset = (uintptr_t)(SymPtr -<br>
                                            (const uint8_t*)SectionData.begin());<br>
-        unsigned SectionID =<br>
-          findOrEmitSection(*obj,<br>
-                            *si,<br>
-                            SymType == object::SymbolRef::ST_Function,<br>
-                            LocalSections);<br>
+        unsigned SectionID = findOrEmitSection(*obj, *si, IsCode, LocalSections);<br>
         LocalSymbols[Name.data()] = SymbolLoc(SectionID, SectOffset);<br>
         DEBUG(dbgs() << "\tFileOffset: " << format("%p", (uintptr_t)FileOffset)<br>
                      << " flags: " << flags<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></div>