<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div><div><br><div><div>On Dec 14, 2012, at 10:45 AM, David Majnemer wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Ping.<div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Dec 9, 2012 at 1:06 AM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">There are cases where LLVM chooses to emit andq instructions where an andl instruction would suffice. The latter instruction is advantageous because it is a single byte smaller.<div>
<br></div><div>LLVM already had entries in X86InstrCompiler.td to perform this optimization, however another pattern was being preferred. The attached patch increases the priorities of two patterns so that they will be preferred is they match.</div></blockquote></div></div></blockquote><div><br></div>Hi David,</div><div><br></div><div>Can you please list the other patterns that were preferred before your patch? Just want to make sure it is okay to increase the priorities.</div><div><br></div><div>Thanks,</div><div>Manman</div><div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<div><br></div><div>The attached patch passes all regressions and includes a test to verify that the fix is working.</div>
</blockquote></div><br></div>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>