I've gone ahead and reverted it here temporarily:<div><br></div><div><div>        M       lib/Transforms/InstCombine/InstCombineAddSub.cpp</div><div>Committed r170106</div></div><div><br></div><div>To get some of the bots back since it's been a while.</div>
<div><br></div><div>Hopefully the PR will help Michael with a testcase.</div><div><br></div><div>Thanks all.</div><div><br></div><div>-eric</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 12, 2012 at 8:51 PM, Will Dietz <span dir="ltr"><<a href="mailto:w@wdtz.org" target="_blank">w@wdtz.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ah, wish I saw this thread earlier today :).<br>
<br>
Please see: <a href="http://llvm.org/bugs/show_bug.cgi?id=14592" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=14592</a> .<br>
<br>
Note that while it does break selfhosting for me, it also breaks<br>
llvm/clang when built with gcc (4.4.6).<br>
<br>
Reverting this commit locally un-breaks my build.<br>
<span class="HOEnZb"><font color="#888888"><br>
~Will<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Wed, Dec 12, 2012 at 7:12 PM, Michael Ilseman <<a href="mailto:milseman@apple.com">milseman@apple.com</a>> wrote:<br>
><br>
> On Dec 12, 2012, at 5:02 PM, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br>
><br>
>> Michael, it broke self hosting.<br>
>><br>
><br>
> Do you mean this commit broke it, or that my prior commit broke it and this fixed it?<br>
><br>
>> ...Takumi<br>
>><br>
>> 2012/12/13 Michael Ilseman <<a href="mailto:milseman@apple.com">milseman@apple.com</a>>:<br>
>>> Author: milseman<br>
>>> Date: Wed Dec 12 14:59:36 2012<br>
>>> New Revision: 170024<br>
>>><br>
>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=170024&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=170024&view=rev</a><br>
>>> Log:<br>
>>> Restore the PHI optimization I accidently removed<br>
>>><br>
>>> Modified:<br>
>>>    llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp<br>
>>><br>
>>> Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp<br>
>>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp?rev=170024&r1=170023&r2=170024&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp?rev=170024&r1=170023&r2=170024&view=diff</a><br>

>>> ==============================================================================<br>
>>> --- llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp (original)<br>
>>> +++ llvm/trunk/lib/Transforms/InstCombine/InstCombineAddSub.cpp Wed Dec 12 14:59:36 2012<br>
>>> @@ -354,6 +354,10 @@<br>
>>>   if (Value *V = SimplifyFAddInst(LHS, RHS, I.getFastMathFlags(), TD))<br>
>>>     return ReplaceInstUsesWith(I, V);<br>
>>><br>
>>> +  if (isa<PHINode>(LHS))<br>
>>> +    if (Instruction *NV = FoldOpIntoPhi(I))<br>
>>> +      return NV;<br>
>>> +<br>
>>>   // -A + B  -->  B - A<br>
>>>   // -A + -B  -->  -(A + B)<br>
>>>   if (Value *LHSV = dyn_castFNegVal(LHS))<br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> llvm-commits mailing list<br>
>>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>