Were you going to revert his commit or should I?<div><br></div><div>-eric</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 12, 2012 at 9:03 PM, Nadav Rotem <span dir="ltr"><<a href="mailto:nrotem@apple.com" target="_blank">nrotem@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It looks like Rafael's 170095 is to blame.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Dec 12, 2012, at 8:59 PM, Nadav Rotem <<a href="mailto:nrotem@apple.com">nrotem@apple.com</a>> wrote:<br>
<br>
><br>
> Eric,<br>
><br>
> I am seeing these failures (below) on PPC64, and they look related to debug info. Is it possible that one of your commits broke these tests ?<br>
><br>
> Thanks,<br>
> Nadav<br>
><br>
> • llvm-ppc64-linux1: test llvm 6855 tests 6830 passed 52 warnings 25 failed failed - stdiofailxfailunsupporteddw_at_byte_size.ll2011-12-16-badstructref.lldw_at_specification.lldw_tag_friend.lldw_at_object_pointer.llblock-capture.llempty-and-one-elem-array.llempty-array.llending-run.llenum-fwd-decl.llenum-class.lllinkage-name.llnondefault-subrange-array.lllow-pc-cu.llobjc-fwd-decl.llpointer-type-size.llop_deref.llpr11300.llrvalue-ref.llstruct-loc.ll<br>
> • llvm-ppc64-linux2: test llvm 6855 tests 6830 passed 52 warnings 25 failed failed - stdiofailxfailunsupporteddw_at_byte_size.ll2011-12-16-badstructref.lldw_at_specification.lldw_at_object_pointer.lldw_tag_friend.llblock-capture.llempty-array.llempty-and-one-elem-array.llending-run.llenum-class.llenum-fwd-decl.lllow-pc-cu.lllinkage-name.llnondefault-subrange-array.llobjc-fwd-decl.llpointer-type-size.llpr11300.llop_deref.llrvalue-ref.llstruct-loc.ll<br>
><br>
> On Dec 12, 2012, at 7:00 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:<br>
><br>
>> Author: echristo<br>
>> Date: Wed Dec 12 21:00:38 2012<br>
>> New Revision: 170088<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=170088&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=170088&view=rev</a><br>
>> Log:<br>
>> Use default label name for a section in emitting abbreviation<br>
>> section to help prep some code to be split about.<br>
>><br>
>> Modified:<br>
>> llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
>><br>
>> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=170088&r1=170087&r2=170088&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=170088&r1=170087&r2=170088&view=diff</a><br>
>> ==============================================================================<br>
>> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)<br>
>> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Wed Dec 12 21:00:38 2012<br>
>> @@ -1836,7 +1836,8 @@<br>
>> Asm->OutStreamer.AddComment("DWARF version number");<br>
>> Asm->EmitInt16(dwarf::DWARF_VERSION);<br>
>> Asm->OutStreamer.AddComment("Offset Into Abbrev. Section");<br>
>> - Asm->EmitSectionOffset(Asm->GetTempSymbol("abbrev_begin"),<br>
>> + const MCSection *ASec = Asm->getObjFileLowering().getDwarfAbbrevSection();<br>
>> + Asm->EmitSectionOffset(Asm->GetTempSymbol(ASec->getLabelBeginName()),<br>
>> DwarfAbbrevSectionSym);<br>
>> Asm->OutStreamer.AddComment("Address Size (in bytes)");<br>
>> Asm->EmitInt8(Asm->getDataLayout().getPointerSize());<br>
>> @@ -1860,10 +1861,11 @@<br>
>> // Check to see if it is worth the effort.<br>
>> if (!Abbreviations.empty()) {<br>
>> // Start the debug abbrev section.<br>
>> - Asm->OutStreamer.SwitchSection(<br>
>> - Asm->getObjFileLowering().getDwarfAbbrevSection());<br>
>> + const MCSection *ASec = Asm->getObjFileLowering().getDwarfAbbrevSection();<br>
>> + Asm->OutStreamer.SwitchSection(ASec);<br>
>><br>
>> - Asm->OutStreamer.EmitLabel(Asm->GetTempSymbol("abbrev_begin"));<br>
>> + MCSymbol *Begin = Asm->GetTempSymbol(ASec->getLabelBeginName());<br>
>> + Asm->OutStreamer.EmitLabel(Begin);<br>
>><br>
>> // For each abbrevation.<br>
>> for (unsigned i = 0, N = Abbreviations.size(); i < N; ++i) {<br>
>> @@ -1880,7 +1882,8 @@<br>
>> // Mark end of abbreviations.<br>
>> Asm->EmitULEB128(0, "EOM(3)");<br>
>><br>
>> - Asm->OutStreamer.EmitLabel(Asm->GetTempSymbol("abbrev_end"));<br>
>> + MCSymbol *End = Asm->GetTempSymbol(ASec->getLabelEndName());<br>
>> + Asm->OutStreamer.EmitLabel(End);<br>
>> }<br>
>> }<br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
</div></div></blockquote></div><br></div>