<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt">test? <br><br><div class="gmail_quote">On Mon, Dec 10, 2012 at 8:02 PM, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com" target="_blank">glider@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: glider<br>
Date: Mon Dec 10 10:02:13 2012<br>
New Revision: 169736<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=169736&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=169736&view=rev</a><br>
Log:<br>
[ASan] Typo fix in memcpy() and memmove() interceptors: ASAN_WRITE_RANGE and ASAN_READ_RANGE were swapped.<br>
This has been spotted by Anna Zaks (<a href="mailto:ganna@apple.com">ganna@apple.com</a>)<br>
<br>
Modified:<br>
compiler-rt/trunk/lib/asan/asan_interceptors.cc<br>
<br>
Modified: compiler-rt/trunk/lib/asan/asan_interceptors.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_interceptors.cc?rev=169736&r1=169735&r2=169736&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_interceptors.cc?rev=169736&r1=169735&r2=169736&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/asan/asan_interceptors.cc (original)<br>
+++ compiler-rt/trunk/lib/asan/asan_interceptors.cc Mon Dec 10 10:02:13 2012<br>
@@ -277,8 +277,8 @@<br>
// See <a href="http://llvm.org/bugs/show_bug.cgi?id=11763" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=11763</a>.<br>
CHECK_RANGES_OVERLAP("memcpy", to, size, from, size);<br>
}<br>
- ASAN_WRITE_RANGE(from, size);<br>
- ASAN_READ_RANGE(to, size);<br>
+ ASAN_READ_RANGE(from, size);<br>
+ ASAN_WRITE_RANGE(to, size);<br>
}<br>
#if MAC_INTERPOSE_FUNCTIONS<br>
// Interposing of resolver functions is broken on Mac OS 10.7 and 10.8.<br>
@@ -296,8 +296,8 @@<br>
}<br>
ENSURE_ASAN_INITED();<br>
if (flags()->replace_intrin) {<br>
- ASAN_WRITE_RANGE(from, size);<br>
- ASAN_READ_RANGE(to, size);<br>
+ ASAN_READ_RANGE(from, size);<br>
+ ASAN_WRITE_RANGE(to, size);<br>
}<br>
#if MAC_INTERPOSE_FUNCTIONS<br>
// Interposing of resolver functions is broken on Mac OS 10.7 and 10.8.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>