<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Dec 4, 2012, at 9:04 AM, Weiming Zhao <<a href="mailto:weimingz@codeaurora.org">weimingz@codeaurora.org</a>> wrote:</div><blockquote type="cite"><div lang="EN-US" link="blue" vlink="purple"><div class="WordSection1"><div><div><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><br></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">I have to change CodeGen/SelectionDAG/InstrEmitter.cpp a litte bit because: for the inline asm nodes, I have to put a virtual reg instead of a value node.</span></p></div></div></div></div></div></blockquote><div><br></div><div>Hi Weiming,</div><div><br></div><div>I'm a bit concerned about this change. A RegisterSDNode doesn't include any kind of dependency edges, so you have a 50/50 chance of you virtual register def coming before your use. I don't think you can use virtual registers in the SelectionDAG that way.</div><div><br></div><blockquote type="cite"><div lang="EN-US" link="blue" vlink="purple"><div class="WordSection1"><div><div><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p></o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">And due to “untyped” type, I can’t insert CopyFromReg or CopyToReg as the framework won’t find the GPRPairReg class.<o:p></o:p></span></p></div><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">So I have to directly connect ExtractSubReg, RegSequence with a Register SDNode.</span></p></div></div></div></div></div></blockquote><div><br></div><div>An 'untyped' SelectionDAG edge only works when InstrEmitter can derive its register class from the defining node. That currently works for REG_SEQUENCE nodes - you probably need to make it work for INLINEASM nodes as well.</div><div><br></div><div>It would also be a good idea to break your patch in two: One part for providing the target-independent framework needed, and one part that fixes the ARM target.</div><div><br></div><div>/jakob</div><div><br></div></div><style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style></body></html>