<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt">Agreed. r169121.<br><br><div class="gmail_quote">On Mon, Dec 3, 2012 at 3:20 PM, Dmitri Gribenko <span dir="ltr"><<a href="mailto:gribozavr@gmail.com" target="_blank">gribozavr@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Mon, Dec 3, 2012 at 11:43 AM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br>

> Modified: compiler-rt/trunk/lib/asan/tests/asan_test_utils.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_test_utils.h?rev=169118&r1=169117&r2=169118&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_test_utils.h?rev=169118&r1=169117&r2=169118&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/lib/asan/tests/asan_test_utils.h (original)<br>
> +++ compiler-rt/trunk/lib/asan/tests/asan_test_utils.h Mon Dec  3 03:43:56 2012<br>
> @@ -68,4 +68,8 @@<br>
>    return ret;<br>
>  }<br>
><br>
> +// Check that pthread_create/pthread_join return success.<br>
> +#define PTHREAD_CREATE(a, b, c, d) EXPECT_EQ(0, pthread_create(a, b, c, d))<br>
> +#define PTHREAD_JOIN(a, b) EXPECT_EQ(0, pthread_join(a, b))<br>
> +<br>
>  #endif  // ASAN_TEST_UTILS_H<br>
<br>
</div>Hello Kostya,<br>
<br>
I think you could use ASSERT_EQ here, since it does not make sense to<br>
continue if pthread_* fails.<br>
<span class="HOEnZb"><font color="#888888"><br>
Dmitri<br>
<br>
--<br>
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if<br>
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <<a href="mailto:gribozavr@gmail.com">gribozavr@gmail.com</a>>*/<br>
</font></span></blockquote></div><br></div>