Pawel,<br><br>Please merge the eight patches I mentioned in my previous email. I did additional testing and I found no problems. They can be merged without any modifications.<br><br>r168471<br>r168460<br>r168458<br>r168456<br>
r168455<br>r168453<br>r168450<br>r168448<br>
<br>Also, I would like to have the following patch merged, if possible: <br><br>r169098<br><a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121126/068982.html">http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20121126/068982.html</a><br>
<br>This patch adds mxgot command line options to clang driver.<br><br>Is it okay to merge this patch (cc'ing Chad who is the code owner of this part)?<br><br><div class="gmail_quote">On Fri, Nov 30, 2012 at 10:41 AM, Pawel Wodnicki <span dir="ltr"><<a href="mailto:pawel@32bitmicro.com" target="_blank">pawel@32bitmicro.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
> It sounds like we're holding off on these, but for the record, r168448 is fine to go in if we get another window of opportunity.<br>
<br>
</div>Great, r168448 was the one holding the merge, the rest are MIPS only<br>
so any problems would probably affect only MIPS target.<br>
<br>
Anyway, RC2 went ahead as scheduled but I am sure we will find<br>
some issues in testing. So I will do RC3 by middle of next<br>
week (Wednesday), this will be a good time to incorporate MIPS patches.<br>
<br>
In the mean time I guess Akira could continue testing<br>
and or refining these changes as necessary. I am not<br>
really setup to test MIPS beyond make check-all, unless<br>
I dust off my SGI O2 or better re-purpose some wirelesses router :)<br>
<div class="im"><br>
>I tested the patches, and they shouldn't have any problems.<br>
<br>
</div>At this point I get a bit uncomfortable with "shouldn't<br>
have any problems", I want "Sure, no problem just merge them!".<br>
Also, if you have any changes to these patches please allow me<br>
24h for processing, just tell me by Tuesday next week what to merge.<br>
<span class="HOEnZb"><font color="#888888"><br>
Pawel<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
><br>
> -Jim<br>
><br>
> On Nov 29, 2012, at 6:49 PM, NAKAMURA Takumi <<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>> wrote:<br>
><br>
>> Jim, could you approve r168448, "Add relocations used for mips big GOT."?<br>
>> llvm/include/llvm/MC/MCExpr.h<br>
>> llvm/lib/MC/MCExpr.cpp<br>
>><br>
>> Others (lib/Target/Mips) should be owned de-facto by Mips guys, I<br>
>> suppose, though.<br>
>> I think Evan could approve them in this case.<br>
>><br>
>> Pawel, FYI, they, 8 commits, can be applied cleanly into release_32<br>
>> and can be built w/o warnings nor failures.<br>
>><br>
>> llvm/include/llvm/MC/MCExpr.h | 6 +-<br>
>> llvm/lib/MC/MCExpr.cpp | 4 +<br>
>> llvm/lib/Target/Mips/InstPrinter/MipsInstPrinter.cpp | 4 +<br>
>> llvm/lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp | 10 +-<br>
>> llvm/lib/Target/Mips/MCTargetDesc/MipsBaseInfo.h | 8 +-<br>
>> llvm/lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp | 12 +<br>
>> llvm/lib/Target/Mips/MCTargetDesc/MipsFixupKinds.h | 12 +<br>
>> llvm/lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp | 12 +<br>
>> llvm/lib/Target/Mips/Mips64InstrInfo.td | 2 +<br>
>> llvm/lib/Target/Mips/MipsISelLowering.cpp | 257 ++++++-------<br>
>> llvm/lib/Target/Mips/MipsInstrInfo.td | 2 +<br>
>> llvm/lib/Target/Mips/MipsMCInstLower.cpp | 4 +<br>
>> llvm/test/CodeGen/Mips/biggot.ll | 50 +++<br>
>> llvm/test/MC/Mips/xgot.ll | 42 ++<br>
>> 14 files changed, 276 insertions(+), 149 deletions(-)<br>
>><br>
>> ...Takumi<br>
>><br>
>> 2012/11/30 32bitmicro <<a href="mailto:root@32bitmicro.com">root@32bitmicro.com</a>>:<br>
>>> Akira,<br>
>>><br>
>>>> Pawel,<br>
>>>><br>
>>>> Is it still not too late to merge these patches?<br>
>>>><br>
>>>> r168471<br>
>>>> r168460<br>
>>>> r168458<br>
>>>> r168456<br>
>>>> r168455<br>
>>>> r168453<br>
>>>> r168450<br>
>>>> r168448<br>
>>>><br>
>>>> These patches fix a bug in mips backend's GOT implementation and add<br>
>>>> support for big-GOT relocations.<br>
>>><br>
>>> That's quite a list of patches! To get them into the<br>
>>> 3.2 release you would first need to get approval from all<br>
>>> the code owners and then we would have to merge and test.<br>
>>> Frankly, I do not see how we could get all that done<br>
>>> without delaying the release, RC2 deadline is today<br>
>>> at 10p.m. PST.<br>
>>><br>
>>> Pawel<br>
>>><br>
>>>><br>
>>>> Thank you.<br>
>>>><br>
>>>> On Tue, Nov 27, 2012 at 7:35 PM, Pawel Wodnicki <<a href="mailto:root@32bitmicro.com">root@32bitmicro.com</a>> wrote:<br>
>>>><br>
>>>>> Hello,<br>
>>>>><br>
>>>>> Just a quick reminder that the November 29th (10p.m. PST) is the<br>
>>>>> end of Phase 1 testing and Release Candidate 2 (RC2) deadline.<br>
>>>>> After RC2 deadline, LLVM-Clang 3.2 release will be considered feature<br>
>>>>> complete and no new functionality can be added.<br>
>>>>><br>
>>>>> With 2 days left please use following guidelines when<br>
>>>>> initiating request for patches before RC2 deadline.<br>
>>>>><br>
>>>>> I will be happy to merge *approved* patches for low risk/<br>
>>>>> crash fixes that merge cleanly and have simple test case or<br>
>>>>> procedure to verify correctness (aka 1040 EZ Patch).<br>
>>>>><br>
>>>>> Patches that do not fall under the above category need to<br>
>>>>> be classified as either release blocking (discussed below)<br>
>>>>> or non release blocking and thus not included in this release.<br>
>>>>><br>
>>>>><br>
>>>>> Code owners<br>
>>>>><br>
>>>>> I need your input on the state of the release blocking issues as<br>
>>>>> listed in the Bug 13893 - "Umbrella bug for 3.2 release"<br>
>>>>><br>
>>>>> <a href="http://llvm.org/bugs/show_bug.cgi?id=13893" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=13893</a>.<br>
>>>>><br>
>>>>> Please review the list below and let me know whether the<br>
>>>>> listed bugs can be (better yet will be!) fixed in the Phase 2.<br>
>>>>><br>
>>>>> If there are other release stopping bugs/issues that you<br>
>>>>> think should be fixed before the final 3.2 release but<br>
>>>>> are not listed below then please add them to the<br>
>>>>> Bug 13893 - "Umbrella bug for 3.2 release".<br>
>>>>><br>
>>>>><br>
>>>>><br>
>>>>> As of today Tuesday Nov 27th following release blocking<br>
>>>>> bugs are still open:<br>
>>>>><br>
>>>>> 12664 - O2 -ftree-vectorize -fplugin-arg-dragonegg-enable-gcc-optzns on<br>
>>>>> mdbx.f90 confuses dragoneg<br>
>>>>><br>
>>>>> 13561 - LLVM ERROR: Cannot select: 0x14214bb10: i16 =<br>
>>>>> extract_vector_elt 0x14214b910, 0x142142c10<br>
>>>>><br>
>>>>> 14116 - Inliner incorrectly combines cleanup and catch landing pads<br>
>>>>><br>
>>>>> 14279 - mishandling of implicit move in class with copy-only member<br>
>>>>><br>
>>>>> 14337 - UNREACHABLE executed at CallingConvLower.cpp:111 when returning<br>
>>>>> v4f64 on ARM<br>
>>>>><br>
>>>>> 14429 - Dragonegg fails to build clang<br>
>>>>><br>
>>>>><br>
>>>>> Pawel<br>
>>>>> _______________________________________________<br>
>>>>> LLVM Developers mailing list<br>
>>>>> <a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
>>>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
>>>>><br>
>>>><br>
>>><br>
>>> _______________________________________________<br>
>>> LLVM Developers mailing list<br>
>>> <a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
><br>
><br>
><br>
<br>
</div></div></blockquote></div><br>