On Sat, Nov 17, 2012 at 9:39 PM, Nick Lewycky <span dir="ltr"><<a href="mailto:nicholas@mxc.ca" target="_blank">nicholas@mxc.ca</a>></span> wrote:<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Modified: llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp?rev=168280&r1=168279&r2=168280&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp?rev=168280&r1=168279&r2=168280&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp Sat Nov 17 23:39:39 2012<br>
@@ -164,7 +164,8 @@<br>
       return TD.getPreferredAlignment(GV);<br>
<br>
   if (PointerType *PT = dyn_cast<PointerType>(V->getType()))<br>
-    return TD.getABITypeAlignment(PT->getElementType());<br>
+    if (PT->getElementType()->isSized())<br>
+      return TD.getABITypeAlignment(PT->getElementType());<br></blockquote><div><br></div><div>Actually, this code is still buggy. It's not safe to rely on the ElementType of a pointer type to indicate alignment at all. This code should just be removed altogether.</div>
<div><br></div><div>Dan</div><div><br></div></div>