My primary goal was to keep instruction selection from failing. Without the change I made, FABS of v4f32 just didn't match anything and failed. Someone familiar with ARM could maybe do something better.<div><br><div class="gmail_quote">
On Thu, Nov 15, 2012 at 9:52 AM, David Peixotto <span dir="ltr"><<a href="mailto:dpeixott@codeaurora.org" target="_blank">dpeixott@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Craig,<br>
<br>
I see the change was reverted for FNEG, but what about FABS? Why does FABS<br>
need to be marked as expand here? There is a VABS.f32 instruction that<br>
operates on Q registers that should work for a v4f32 type. Will that<br>
instruction be generated when it is marked expand?<br>
<br>
Thanks,<br>
David<br>
<br>
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted<br>
by The Linux Foundation<br>
<br>
<br>
> -----Original Message-----<br>
> From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvm-commits-">llvm-commits-</a><br>
> <a href="mailto:bounces@cs.uiuc.edu">bounces@cs.uiuc.edu</a>] On Behalf Of Craig Topper<br>
> Sent: Thursday, November 15, 2012 12:06 AM<br>
> To: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> Subject: [llvm-commits] [llvm] r168029 -<br>
> /llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp<br>
><br>
> Author: ctopper<br>
> Date: Thu Nov 15 02:06:12 2012<br>
> New Revision: 168029<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=168029&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=168029&view=rev</a><br>
> Log:<br>
> Make FNEG and FABS of v4f32 Expand.<br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-" target="_blank">http://llvm.org/viewvc/llvm-</a><br>
> project/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp?rev=168029&r1=1<br>
> 68028&r2=168029&view=diff<br>
> ==========================================================<br>
> ====================<br>
> --- llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (original)<br>
> +++ llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp Thu Nov 15 02:06:12<br>
> 2012<br>
> @@ -505,6 +505,8 @@<br>
>      setOperationAction(ISD::FNEARBYINT, MVT::v2f64, Expand);<br>
>      setOperationAction(ISD::FFLOOR, MVT::v2f64, Expand);<br>
><br>
> +    setOperationAction(ISD::FNEG, MVT::v4f32, Expand);<br>
> +    setOperationAction(ISD::FABS, MVT::v4f32, Expand);<br>
>      setOperationAction(ISD::FSQRT, MVT::v4f32, Expand);<br>
>      setOperationAction(ISD::FSIN, MVT::v4f32, Expand);<br>
>      setOperationAction(ISD::FCOS, MVT::v4f32, Expand);<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig<br>
</div>