<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Sorry, I will fix this shortly.<br>
<br>
<br>
On 11/02/2012 03:08 PM, Michael Gottesman wrote:<br>
</div>
<blockquote
cite="mid:0AD7E1CF-1525-446A-9A53-4D09EA43BA53@apple.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<div>I am getting test failures for</div>
<div>
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">LLVM :: MC/Disassembler/Mips/mips64.txt
LLVM :: MC/Disassembler/Mips/mips64_le.txt
LLVM :: MC/Disassembler/Mips/mips64r2.txt
LLVM :: MC/Disassembler/Mips/mips64r2_le.txt</span></pre>
<div>from this commit even on builds that ran after your text
case fix in 167322. The specific error messages are:</div>
</div>
<div><br>
</div>
<div>
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">------</span></pre>
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">MC/Disassembler/Mips/mips64.txt</span></pre>
</div>
<div>
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"># CHECK: daddu $26, $at, $11
^
<stdin>:3:2: note: scanning from here
daddu $26, $1, $11</span></pre>
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">------</span></pre>
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">M</span>C/Disassembler/Mips/mips64_le.txt</pre>
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"># CHECK: daddu $26, $at, $11
^
<stdin>:3:2: note: scanning from here
daddu $26, $1, $11
^
<pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">------</span></pre><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">MC/Disassembler/Mips/mips64r2.txt</span></pre></span></pre><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"># CHECK: daddu $26, $at, $11
^
<stdin>:3:2: note: scanning from here
daddu $26, $1, $11</span></pre></span></pre><div><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">------</span></pre><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">MC/Disassembler/Mips/mips64r2_le.txt</span></pre></span></pre><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout"># CHECK: daddu $26, $at, $11
^
<stdin>:3:2: note: scanning from here
daddu $26, $1, $11
^</span></pre></span></pre><div><pre style="font-family: 'Courier New', courier, monotype; "><span class="stdout">------</span></pre></div></div></span></pre></span></pre>
<div>This revision has not hit the public darwin builders yet,
so I imagine it is going to break the build soon.</div>
</div>
<br>
<div>
<div>On Nov 2, 2012, at 2:26 PM, Akira Hatanaka <<a
moz-do-not-send="true" href="mailto:ahatanaka@mips.com">ahatanaka@mips.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">Author: ahatanak<br>
Date: Fri Nov 2 16:26:03 2012<br>
New Revision: 167315<br>
<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project?rev=167315&view=rev">http://llvm.org/viewvc/llvm-project?rev=167315&view=rev</a><br>
Log:<br>
[mips] Use register number instead of name to print register
$AT.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/Mips/MipsRegisterInfo.td<br>
llvm/trunk/test/CodeGen/Mips/largeimm1.ll<br>
llvm/trunk/test/CodeGen/Mips/largeimmprinting.ll<br>
llvm/trunk/test/CodeGen/Mips/longbranch.ll<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/MipsRegisterInfo.td<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsRegisterInfo.td?rev=167315&r1=167314&r2=167315&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsRegisterInfo.td?rev=167315&r1=167314&r2=167315&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/MipsRegisterInfo.td (original)<br>
+++ llvm/trunk/lib/Target/Mips/MipsRegisterInfo.td Fri Nov 2
16:26:03 2012<br>
@@ -73,7 +73,7 @@<br>
let Namespace = "Mips" in {<br>
// General Purpose Registers<br>
def ZERO : MipsGPRReg< 0, "zero">,
DwarfRegNum<[0]>;<br>
- def AT : MipsGPRReg< 1, "at">,
DwarfRegNum<[1]>;<br>
+ def AT : MipsGPRReg< 1, "1">,
DwarfRegNum<[1]>;<br>
def V0 : MipsGPRReg< 2, "2">,
DwarfRegNum<[2]>;<br>
def V1 : MipsGPRReg< 3, "3">,
DwarfRegNum<[3]>;<br>
def A0 : MipsGPRReg< 4, "4">,
DwarfRegNum<[4]>;<br>
@@ -107,7 +107,7 @@<br>
<br>
// General Purpose 64-bit Registers<br>
def ZERO_64 : Mips64GPRReg< 0, "zero", [ZERO]>,
DwarfRegNum<[0]>;<br>
- def AT_64 : Mips64GPRReg< 1, "at", [AT]>,
DwarfRegNum<[1]>;<br>
+ def AT_64 : Mips64GPRReg< 1, "1", [AT]>,
DwarfRegNum<[1]>;<br>
def V0_64 : Mips64GPRReg< 2, "2", [V0]>,
DwarfRegNum<[2]>;<br>
def V1_64 : Mips64GPRReg< 3, "3", [V1]>,
DwarfRegNum<[3]>;<br>
def A0_64 : Mips64GPRReg< 4, "4", [A0]>,
DwarfRegNum<[4]>;<br>
<br>
Modified: llvm/trunk/test/CodeGen/Mips/largeimm1.ll<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/largeimm1.ll?rev=167315&r1=167314&r2=167315&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/largeimm1.ll?rev=167315&r1=167314&r2=167315&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/Mips/largeimm1.ll (original)<br>
+++ llvm/trunk/test/CodeGen/Mips/largeimm1.ll Fri Nov 2
16:26:03 2012<br>
@@ -1,7 +1,7 @@<br>
; RUN: llc -march=mipsel < %s | FileCheck %s<br>
<br>
-; CHECK: lui $at, 49152<br>
-; CHECK: lui $at, 16384<br>
+; CHECK: lui ${{[0-9]+}}, 49152<br>
+; CHECK: lui ${{[0-9]+}}, 16384<br>
define void @f() nounwind {<br>
entry:<br>
%a1 = alloca [1073741824 x i8], align 1<br>
<br>
Modified: llvm/trunk/test/CodeGen/Mips/largeimmprinting.ll<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/largeimmprinting.ll?rev=167315&r1=167314&r2=167315&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/largeimmprinting.ll?rev=167315&r1=167314&r2=167315&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/Mips/largeimmprinting.ll
(original)<br>
+++ llvm/trunk/test/CodeGen/Mips/largeimmprinting.ll Fri Nov
2 16:26:03 2012<br>
@@ -6,9 +6,9 @@<br>
<br>
define void @f() nounwind {<br>
entry:<br>
-; CHECK: lui $at, 65535<br>
-; CHECK: addiu $at, $at, -16<br>
-; CHECK: addu $sp, $sp, $at<br>
+; CHECK: lui $[[R0:[0-9]+]], 65535<br>
+; CHECK: addiu $[[R0]], $[[R0]], -16<br>
+; CHECK: addu $sp, $sp, $[[R0]]<br>
<br>
%agg.tmp = alloca %struct.S1, align 1<br>
%tmp = getelementptr inbounds %struct.S1* %agg.tmp, i32 0,
i32 0, i32 0<br>
<br>
Modified: llvm/trunk/test/CodeGen/Mips/longbranch.ll<br>
URL: <a moz-do-not-send="true"
href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/longbranch.ll?rev=167315&r1=167314&r2=167315&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Mips/longbranch.ll?rev=167315&r1=167314&r2=167315&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/Mips/longbranch.ll (original)<br>
+++ llvm/trunk/test/CodeGen/Mips/longbranch.ll Fri Nov 2
16:26:03 2012<br>
@@ -6,15 +6,15 @@<br>
define void @foo1(i32 %s) nounwind {<br>
entry:<br>
; O32: bal<br>
-; O32: lui $at, 0<br>
-; O32: addiu $at, $at, {{[0-9]+}} <br>
-; N64: lui $at, 0<br>
-; N64: daddiu $at, $at, 0<br>
-; N64: dsll $at, $at, 16<br>
-; N64: daddiu $at, $at, 0<br>
+; O32: lui $1, 0<br>
+; O32: addiu $1, $1, {{[0-9]+}} <br>
+; N64: lui $1, 0<br>
+; N64: daddiu $1, $1, 0<br>
+; N64: dsll $1, $1, 16<br>
+; N64: daddiu $1, $1, 0<br>
; N64: bal<br>
-; N64: dsll $at, $at, 16<br>
-; N64: daddiu $at, $at, {{[0-9]+}} <br>
+; N64: dsll $1, $1, 16<br>
+; N64: daddiu $1, $1, {{[0-9]+}} <br>
<br>
%tobool = icmp eq i32 %s, 0<br>
br i1 %tobool, label %if.end, label %if.then<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</blockquote>
<br>
</body>
</html>