<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 2, 2012, at 10:35 AM, Shankar Easwaran wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
<div text="#000000" bgcolor="#FFFFFF">
Hi Nick,<br>
<br>
<blockquote cite="mid:43F1E1BE-3374-455E-B616-266E983A583A@apple.com" type="cite">
<div>
<div>On Nov 2, 2012, at 8:03 AM, Shankar Easwaran wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica;
font-style: normal; font-variant: normal; font-weight:
normal; letter-spacing: normal; line-height: normal;
orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2;
word-spacing: 0px; -webkit-border-horizontal-spacing: 0px;
-webkit-border-vertical-spacing: 0px;
-webkit-text-decorations-in-effect: none;
-webkit-text-size-adjust: auto; -webkit-text-stroke-width:
0px; font-size: medium; ">I had a thought on the same
approach too, the problem was ReaderELF had to be passed
ReaderArchive too (or) at a bare minimum the
ReaderArchiveOptions.<span class="Apple-converted-space"> </span><br>
This would have broken things with other Readers. I
discussed with Michael on IRC and he said putting it in File
should be fine for now.<br>
</span></blockquote>
<div>How would this have broken other readers? In my proposal,
ReaderELF would instantiate a ReaderArchive passing "this" for
the ReaderArchiveOptions reader.</div>
<div><br>
</div>
</div>
</blockquote>
The ReaderArchiveOptions gets constructed using the command line
flags thats passed to lld, along with the Reader. For the
ReaderArchiveOptions to be created within ReaderELF,<br>
the command line options (or) the appropriate flags that were read
from the command line would be needed. <br>
<br>
Currently all the Readers(createReader*) take in ReaderOptionsELF
only. </div></blockquote><br></div><div><br></div><div>You just defined class ReaderOptionsArchive with one constructor:</div><div><br></div><div> ReaderOptionsArchive(Reader *reader, int argc, char *argv[]);</div><div><br></div><div>but it never uses the command line args. Why not add another constructor:</div><div><br></div><div><div> ReaderOptionsArchive(Reader *reader);</div><div><br></div><div>Other readers can use that constructor until the command line option handling is worked out.</div><div><br></div><div>-Nick</div><div><br></div><div><br></div></div></body></html>