Thanks for the reminder. I added check strings to tailcall.ll in r167139.<br><br><div class="gmail_quote">On Tue, Oct 30, 2012 at 8:05 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">testcase?<br>
<div class="HOEnZb"><div class="h5"><br>
On 30 October 2012 15:07, Akira Hatanaka <<a href="mailto:ahatanaka@mips.com">ahatanaka@mips.com</a>> wrote:<br>
> Author: ahatanak<br>
> Date: Tue Oct 30 14:07:58 2012<br>
> New Revision: 167039<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=167039&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=167039&view=rev</a><br>
> Log:<br>
> Do not do tail-call optimization if target is mips16.<br>
><br>
><br>
> Modified:<br>
>     llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=167039&r1=167038&r2=167039&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=167039&r1=167038&r2=167039&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)<br>
> +++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Tue Oct 30 14:07:58 2012<br>
> @@ -2665,6 +2665,10 @@<br>
>    if (!EnableMipsTailCalls)<br>
>      return false;<br>
><br>
> +  // No tail call optimization for mips16.<br>
> +  if (Subtarget->inMips16Mode())<br>
> +    return false;<br>
> +<br>
>    if (MipsCCInfo.hasByValArg() || IsVarArg)<br>
>      return false;<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br>