Nope - definitely not right. Thanks for catching it. Fixed in r166994.<br><br>- Lang.<br><br><div class="gmail_quote">On Mon, Oct 29, 2012 at 10:19 AM, Daniel Dunbar <span dir="ltr"><<a href="mailto:daniel@zuster.org" target="_blank">daniel@zuster.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Lang,<br>
<div><div class="h5"><br>
On Fri, Oct 26, 2012 at 4:06 PM, Lang Hames <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:<br>
> Author: lhames<br>
> Date: Fri Oct 26 18:06:41 2012<br>
> New Revision: 166831<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=166831&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=166831&view=rev</a><br>
> Log:<br>
> Auto-derive another SPEC define from the compiler's built-in defines.<br>
><br>
> Modified:<br>
>     test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile<br>
>     test-suite/trunk/tools/<a href="http://TargetConfig.mk.in" target="_blank">TargetConfig.mk.in</a><br>
><br>
> Modified: test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile?rev=166831&r1=166830&r2=166831&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile?rev=166831&r1=166830&r2=166831&view=diff</a><br>

> ==============================================================================<br>
> --- test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile (original)<br>
> +++ test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile Fri Oct 26 18:06:41 2012<br>
> @@ -13,14 +13,15 @@<br>
><br>
>  include $(LEVEL)/Makefile.config<br>
><br>
> +ifdef ARCH_HAS_LONGLONG<br>
> +  CPPFLAGS += -DHAS_LONGLONG<br>
> +endif<br>
> +<br>
>  ifeq ($(ARCH),Alpha)<br>
>    CPPFLAGS += -DALPHA -DLINUX<br>
>  endif<br>
> -ifeq ($(ARCH),x86)<br>
> -  CPPFLAGS += -DHAS_LONGLONG<br>
> -endif<br>
>  ifeq ($(ARCH),x86_64)<br>
> -  CPPFLAGS += -DLONG_HAS_64BITS -DHAS_LONGLONG<br>
> +  CPPFLAGS += -DLONG_HAS_64BITS<br>
>  endif<br>
>  ifeq ($(ARCH),PowerPC)<br>
>     CPPFLAGS += -DLINUX_PPC32<br>
> @@ -28,12 +29,6 @@<br>
>  ifeq ($(ARCH),Sparc)<br>
>     CPPFLAGS += -DSUN_BSD<br>
>  endif<br>
> -ifeq ($(ARCH),ARM)<br>
> -  CPPFLAGS += -DHAS_LONGLONG<br>
> -endif<br>
> -ifeq ($(ARCH),THUMB)<br>
> -  CPPFLAGS += -DHAS_LONGLONG<br>
> -endif<br>
>  ifeq ($(TARGET_OS),Darwin)<br>
>    CPPFLAGS += -DUNIX -DLINUX<br>
>  endif<br>
><br>
> Modified: test-suite/trunk/tools/<a href="http://TargetConfig.mk.in" target="_blank">TargetConfig.mk.in</a><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/test-suite/trunk/tools/TargetConfig.mk.in?rev=166831&r1=166830&r2=166831&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/test-suite/trunk/tools/TargetConfig.mk.in?rev=166831&r1=166830&r2=166831&view=diff</a><br>

> ==============================================================================<br>
> --- test-suite/trunk/tools/<a href="http://TargetConfig.mk.in" target="_blank">TargetConfig.mk.in</a> (original)<br>
> +++ test-suite/trunk/tools/<a href="http://TargetConfig.mk.in" target="_blank">TargetConfig.mk.in</a> Fri Oct 26 18:06:41 2012<br>
> @@ -5,6 +5,7 @@<br>
><br>
>  #ifdef __LP64__<br>
>  ARCH_LP64 := YES<br>
> +ARCH_HAS_LONGLONG := YES<br>
<br>
</div></div>Is this really right? HAS_LONGLONG doesn't have anything to do with<br>
whether or not the platform is LP64. If you check against your changes<br>
to the crafty Makefile you will see HAS_LONGLONG used to get set in<br>
many more places.<br>
<span class="HOEnZb"><font color="#888888"><br>
 - Daniel<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
>  #endif<br>
><br>
>  #ifdef __LITTLE_ENDIAN__<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br>