I believe those errors are from gcc. Clang's error messages in this case seem a lot less useful as they don't give any hint that the problem in the subclasses is with ~Operator() being private.<br><br><div class="gmail_quote">
On Wed, Oct 24, 2012 at 3:53 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Are those the errors from gcc? I noticed clang bootstrap was failing, but I don't think it flagged the private ~Operator() which made it really non obvious why it was failing.<div class="HOEnZb"><div class="h5"><br><br>
<div class="gmail_quote">On Wed, Oct 24, 2012 at 12:17 PM, Kaelyn Uhrain <span dir="ltr"><<a href="mailto:rikka@google.com" target="_blank">rikka@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rikka<br>
Date: Wed Oct 24 14:17:42 2012<br>
New Revision: 166611<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=166611&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=166611&view=rev</a><br>
Log:<br>
Make ~Operator() protected so subclasses can inherit it and not have<br>
a bunch of errors for all the Operator subclasses such as:<br>
<br>
include/llvm/Operator.h:76:7: error: deleted function 'virtual llvm::OverflowingBinaryOperator::~OverflowingBinaryOperator()'<br>
include/llvm/Operator.h:43:3: error: overriding non-deleted function 'virtual llvm::Operator::~Operator()'<br>
include/llvm/Operator.h:76:7: error: 'virtual llvm::OverflowingBinaryOperator::~OverflowingBinaryOperator()' is implicitly deleted because the default definition would be ill-formed:<br>
include/llvm/Operator.h:43:3: error: 'virtual llvm::Operator::~Operator()' is private<br>
include/llvm/Operator.h:76:7: error: within this context<br>
<br>
Modified:<br>
    llvm/trunk/include/llvm/Operator.h<br>
<br>
Modified: llvm/trunk/include/llvm/Operator.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Operator.h?rev=166611&r1=166610&r2=166611&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Operator.h?rev=166611&r1=166610&r2=166611&view=diff</a><br>


==============================================================================<br>
--- llvm/trunk/include/llvm/Operator.h (original)<br>
+++ llvm/trunk/include/llvm/Operator.h Wed Oct 24 14:17:42 2012<br>
@@ -37,6 +37,7 @@<br>
   void *operator new(size_t s) LLVM_DELETED_FUNCTION;<br>
   Operator() LLVM_DELETED_FUNCTION;<br>
<br>
+protected:<br>
   // NOTE: Cannot use LLVM_DELETED_FUNCTION because it's not legal to delete<br>
   // an overridden method that's not deleted in the base class. Cannot leave<br>
   // this unimplemented because that leads to an ODR-violation.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br>~Craig<br>
</font></span></blockquote></div><br>