On Thu, Oct 18, 2012 at 1:17 PM, Tobias Grosser <span dir="ltr"><<a href="mailto:tobias@grosser.es" target="_blank" class="cremed">tobias@grosser.es</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On 10/18/2012 10:11 PM, David Blaikie wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Oct 18, 2012 at 1:08 PM, Tobias Grosser <<a href="mailto:tobias@grosser.es" target="_blank" class="cremed">tobias@grosser.es</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 10/18/2012 08:34 PM, Nadav Rotem wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Author: nadav<br>
Date: Thu Oct 18 13:34:50 2012<br>
New Revision: 166205<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=166205&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-<u></u>project?rev=166205&view=rev</a><br>
Log:<br>
Avoid reconstructing the pointer set when searching for duplicated<br>
read/write pointers.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Transforms/<u></u>Vectorize/LoopVectorize.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/<u></u>Vectorize/LoopVectorize.cpp<br>
URL:<br>
<a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp?rev=166205&r1=166204&r2=166205&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-<u></u>project/llvm/trunk/lib/<u></u>Transforms/Vectorize/<u></u>LoopVectorize.cpp?rev=166205&<u></u>r1=166204&r2=166205&view=diff</a><br>
<br>
==============================<u></u>==============================<u></u>==================<br>
--- llvm/trunk/lib/Transforms/<u></u>Vectorize/LoopVectorize.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/<u></u>Vectorize/LoopVectorize.cpp Thu Oct 18<br>
13:34:50 2012<br>
@@ -166,7 +166,7 @@<br>
<br>
// Check if a pointer value is known to be disjoint.<br>
// Example: Alloca, Global, NoAlias.<br>
- bool isKnownDisjoint(Value* Val);<br>
+ bool isidentifiedSafeObject(Value* Val);<br>
</blockquote>
<br>
<br>
Should this be 'isIdentifiedSafeObject()' ?<br>
^ uppercase<br>
</blockquote>
<br>
"Function names should be verb phrases (as they represent actions),<br>
and command-like function should be imperative. The name should be<br>
camel case, and start with a lower case letter (e.g. openFile() or<br>
isFoo())."<br>
<br>
- <a href="http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly" target="_blank" class="cremed">http://llvm.org/docs/<u></u>CodingStandards.html#name-<u></u>types-functions-variables-and-<u></u>enumerators-properly</a><br>
<br>
It's inconsistent across the codebase because this particular standard<br>
wasn't in place from the start. Generally the rule is to be consistent<br>
with existing code (within a class, file, etc) but if you're making<br>
large changes you can take the opportunity to clean things up.<br>
</blockquote>
<br></div></div>
I am not sure what you want to say here. Do you agree or disagree with my remark?<br>
<br>
It is just a detail, but should the third letter not be uppercase due to the cameCase requirement in the coding standard?<br></blockquote><div><br></div><div>I think that you're likely in agreement, and David may just have a proportional width font.... ;]</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Tobi<div class="HOEnZb"><div class="h5"><br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>