<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><base href="x-msg://4813/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Sep 27, 2012, at 9:38 AM, "Villmow, Micah" <<a href="mailto:Micah.Villmow@amd.com">Micah.Villmow@amd.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div lang="EN-US" link="blue" vlink="purple" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div class="WordSection1" style="page: WordSection1; "><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">I have attached the patch required to support SPIR in LLVM. This patch will allow all vendors who wish to support SPIR as a target the ability to share binaries with the same enums and calling conventions.<o:p></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><o:p> </o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">The discussion on calling conventions in SPIR is here:<o:p></o:p></div></div></div></blockquote><br></div><div>Looks fine, but please add an underscore to the asm syntax (and enums) for the new calling conventions. Also, you should probably just spell out kernel. This would give you "spir_kernel" as the calling convention.</div><div><br></div><div>-Chris</div><br></body></html>