<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">It's not really a phase ordering issue per say. But I don't see a better place for it. Committed as r164867.<div><br></div><div>Evan</div><div><br><div><div>On Sep 28, 2012, at 2:32 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">On Fri, Sep 28, 2012 at 2:23 PM, Evan Cheng <span dir="ltr"><<a href="mailto:evan.cheng@apple.com" target="_blank" class="cremed">evan.cheng@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: evancheng<br>
Date: Fri Sep 28 16:23:26 2012<br>
New Revision: 164850<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=164850&view=rev" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project?rev=164850&view=rev</a><br>
Log:<br>
GlobalDCE should be run at -O2 / -Os to eliminate unused dtor, etc. <a href="rdar://9142819">rdar://9142819</a><br></blockquote><div><br></div><div>Could you add a test case that shows the phase ordering problem and is fixed by this? I'm thinking something similar to those tests in test/Transforms/PhaseOrdering. We might already have tests that can just have their "-O3" switched to "-O2" or "-Os", but I'd like to have a test that fails if we ever mess this up in the future...</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=164850&r1=164849&r2=164850&view=diff" target="_blank" class="cremed">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp?rev=164850&r1=164849&r2=164850&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/IPO/PassManagerBuilder.cpp Fri Sep 28 16:23:26 2012<br>
@@ -211,13 +211,12 @@<br>
// FIXME: We shouldn't bother with this anymore.<br>
MPM.add(createStripDeadPrototypesPass()); // Get rid of dead prototypes<br>
<br>
- // GlobalOpt already deletes dead functions and globals, at -O3 try a<br>
+ // GlobalOpt already deletes dead functions and globals, at -O2 try a<br>
// late pass of GlobalDCE. It is capable of deleting dead cycles.<br>
- if (OptLevel > 2)<br>
+ if (OptLevel > 1) {<br>
MPM.add(createGlobalDCEPass()); // Remove dead fns and globals.<br>
-<br>
- if (OptLevel > 1)<br>
MPM.add(createConstantMergePass()); // Merge dup global constants<br>
+ }<br>
}<br>
addExtensionsToPM(EP_OptimizerLast, MPM);<br>
}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" class="cremed">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" class="cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>