<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt">I don't see any complaints from anyone, so I will go ahead and commit this by the end of today, or tomorrow.<br><br>- Jan<br><div><span></span><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Jan Sjodin <jan_sjodin@yahoo.com><br> <b><span style="font-weight: bold;">To:</span></b> "Villmow, Micah" <Micah.Villmow@amd.com>; Duncan Sands <baldrick@free.fr>; "llvm-commits@cs.uiuc.edu" <llvm-commits@cs.uiuc.edu> <br> <b><span style="font-weight: bold;">Sent:</span></b> Tuesday,
September 25, 2012 1:48 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [llvm-commits] Patch to add flag in llvm-extract for including aliases in the extraction.<br> </font> </div> <br>
I tried that, but eraseFromParent makes the alias_iterator fail, since the underlying data structure is modified. <br><br><br>- Jan<br><br><br><br>----- Original Message -----<br>> From: "Villmow, Micah" <<a ymailto="mailto:Micah.Villmow@amd.com" href="mailto:Micah.Villmow@amd.com">Micah.Villmow@amd.com</a>><br>> To: Jan Sjodin <<a ymailto="mailto:jan_sjodin@yahoo.com" href="mailto:jan_sjodin@yahoo.com">jan_sjodin@yahoo.com</a>>; Duncan Sands <<a ymailto="mailto:baldrick@free.fr" href="mailto:baldrick@free.fr">baldrick@free.fr</a>>; "<a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>" <<a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>><br>> Cc: <br>> Sent: Tuesday, September 25, 2012 11:34 AM<br>> Subject: RE: [llvm-commits] Patch to add flag in llvm-extract for including aliases in the
extraction.<br>> <br>> So, the patch itself looks fine in its current form, however is there not a way <br>> to delete the alias's without requiring to store them first?<br>> Maybe something like this would work?<br>> +static void extractAliases(Module* M,<br>> + SetVector<GlobalValue *> &GVs) {+ <br>> + // Find aliases to be erased<br>> + for (Module::alias_iterator I = M->alias_begin(), E = M->alias_end();<br>> + I != E; ) {<br>> + GlobalAlias *GA = I++;<br>> + GlobalValue *GV =<br>> + const_cast<GlobalValue*>((GA).resolveAliasedGlobal(false));<br>> + if ((GVs.count(GV) != 0) == DeleteFn)<br>> + GA->eraseFromParent();<br>> + }<br>> +}<br>>
<br>>> -----Original Message-----<br>>> From: <a ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:llvm-commits-<br>>> <a ymailto="mailto:bounces@cs.uiuc.edu" href="mailto:bounces@cs.uiuc.edu">bounces@cs.uiuc.edu</a>] On Behalf Of Jan Sjodin<br>>> Sent: Tuesday, September 25, 2012 6:23 AM<br>>> To: Duncan Sands; <a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>>> Subject: Re: [llvm-commits] Patch to add flag in llvm-extract for<br>>> including aliases in the extraction.<br>>> <br>>> Ok. Re-ping-ping with patch!<br>>> <br>>> - Jan<br>>> <br>>> >________________________________<br>>> > From: Duncan Sands <<a ymailto="mailto:baldrick@free.fr"
href="mailto:baldrick@free.fr">baldrick@free.fr</a>><br>>> >To: <a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>>> >Sent: Saturday, September 22, 2012 6:06 AM<br>>> >Subject: Re: [llvm-commits] Patch to add flag in llvm-extract for<br>>> including aliases in the extraction.<br>>> ><br>>> >On 21/09/12 17:36, Jan Sjodin wrote:<br>>> >><br>>> >> Ping! Ping!<br>>> ><br>>> >Please supply the patch when you ping.<br>>> ><br>>> >Ciao, Duncan.<br>>> >_______________________________________________<br>>> >llvm-commits mailing list<br>>> ><a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>>>
><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>>> ><br>>> ><br>>> ><br>> <br><br>_______________________________________________<br>llvm-commits mailing list<br><a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br><br> </div> </div> </blockquote></div> </div></body></html>