<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM.<div><br><div><div>On Sep 26, 2012, at 4:59 AM, Jush Lu <<a href="mailto:jush.msn@gmail.com">jush.msn@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Ping.<div><br></div><div>The same patch is attached.<br><br><div class="gmail_quote">On Tue, Sep 18, 2012 at 7:18 PM, Jush Lu <span dir="ltr"><<a href="mailto:jush.msn@gmail.com" target="_blank">jush.msn@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Ping.<div><br></div><div>The attachment is the same patch.<div><div class="h5"><br><br><div class="gmail_quote">On Tue, Sep 4, 2012 at 7:14 PM, Jush Lu <span dir="ltr"><<a href="mailto:jush.msn@gmail.com" target="_blank">jush.msn@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><b style="font-family:'LiHei Pro';font-size:medium;font-weight:normal"><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Hi, </span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">This patch adds support for ELF PIC. I know that ARMFastISel hasn’t been used for ELF object files, but I think this patch will be helpful to ELF support.</span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">This patch uses the same way which X86FastISel uses for ELF PIC codegen, you can find the similar code in the “CGBR” pass which is in lib/Target/X86/X86InstrInfo.cpp .</span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">The “ARMCGBR” pass in my patch lowers the value of a ELF specific symbol “_GLOBAL_OFFSET_TABLE_” into a global base register , and this global base register is used by ARMFastISel for ELF PIC codegen.</span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Please review it ,thanks.</span><span><font color="#888888"><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Jush</span></font></span></b></div>
</blockquote></div><br></div></div></div>
</blockquote></div><br></div>
<span><fast-isel-elf-pic.patch></span></blockquote></div><br></div></body></html>