<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt"><div><span>Committed revision 164158. <br></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: arial,helvetica,sans-serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: arial,helvetica,sans-serif; background-color: transparent; font-style: normal;"><span>I left the space unchanged. If you want I can remove the spaces on all the for_each in a separate commit.</span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: arial,helvetica,sans-serif; background-color: transparent; font-style: normal;"><br><span></span></div><div style="color: rgb(0, 0, 0); font-size: 13.3333px; font-family: arial,helvetica,sans-serif; background-color: transparent; font-style: normal;"><span>-
Jan</span></div><div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Chandler Carruth <chandlerc@google.com><br> <b><span style="font-weight: bold;">To:</span></b> Bill Wendling <wendling@apple.com> <br><b><span style="font-weight: bold;">Cc:</span></b> Jan Sjodin <jan_sjodin@yahoo.com>; "llvm-commits@cs.uiuc.edu" <llvm-commits@cs.uiuc.edu> <br> <b><span style="font-weight: bold;">Sent:</span></b> Friday, September 14, 2012 5:32 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.<br> </font> </div> <br>
<div id="yiv2054737993"><div class="yiv2054737993gmail_extra"><div class="yiv2054737993gmail_quote">On Fri, Sep 14, 2012 at 1:54 PM, Bill Wendling <span dir="ltr"><<a rel="nofollow" ymailto="mailto:wendling@apple.com" target="_blank" href="mailto:wendling@apple.com" class="yiv2054737993cremed">wendling@apple.com</a>></span> wrote:<br>
<blockquote class="yiv2054737993gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">I saw that too, but it was like that in the std::for_each's before it, so I didn't bother to pester Jan. :-)<br>
</blockquote><div><br></div><div>This is what I get for only looking at the touched lines. =]</div><div> </div><blockquote class="yiv2054737993gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<span class="yiv2054737993HOEnZb"><font color="#888888"><br>
-bw<br>
</font></span><div class="yiv2054737993im yiv2054737993HOEnZb"><br>
On Sep 14, 2012, at 1:51 PM, Chandler Carruth <<a rel="nofollow" ymailto="mailto:chandlerc@google.com" target="_blank" href="mailto:chandlerc@google.com" class="yiv2054737993cremed">chandlerc@google.com</a>> wrote:<br>
<br>
> Glorious and wonderful with one nit:<br>
><br>
> + if (!WithoutAliases)<br>
> + std::for_each (M->alias_begin(), M->alias_end(),<br>
> + DumpSymbolNameForGlobalValue);<br>
><br>
> No space between 'std::for_each' and the '('. Functions and if statements are different for LLVM's style...<br>
><br>
><br>
> On Fri, Sep 14, 2012 at 7:46 AM, Jan Sjodin <<a rel="nofollow" ymailto="mailto:jan_sjodin@yahoo.com" target="_blank" href="mailto:jan_sjodin@yahoo.com" class="yiv2054737993cremed">jan_sjodin@yahoo.com</a>> wrote:<br>
> New patch with fixed indentation and test case (includes both with and without the new flag).<br>
><br>
> - Jan<br>
><br>
</div><div class="yiv2054737993HOEnZb"><div class="yiv2054737993h5">> From: Chandler Carruth <<a rel="nofollow" ymailto="mailto:chandlerc@google.com" target="_blank" href="mailto:chandlerc@google.com" class="yiv2054737993cremed">chandlerc@google.com</a>><br>
> To: "Villmow, Micah" <<a rel="nofollow" ymailto="mailto:Micah.Villmow@amd.com" target="_blank" href="mailto:Micah.Villmow@amd.com" class="yiv2054737993cremed">Micah.Villmow@amd.com</a>><br>
> Cc: Jan Sjodin <<a rel="nofollow" ymailto="mailto:jan_sjodin@yahoo.com" target="_blank" href="mailto:jan_sjodin@yahoo.com" class="yiv2054737993cremed">jan_sjodin@yahoo.com</a>>; "<a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits@cs.uiuc.edu</a>" <<a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits@cs.uiuc.edu</a>><br>
> Sent: Thursday, September 13, 2012 5:34 PM<br>
><br>
> Subject: Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.<br>
><br>
> On Thu, Sep 13, 2012 at 2:21 PM, Villmow, Micah <<a rel="nofollow" ymailto="mailto:Micah.Villmow@amd.com" target="_blank" href="mailto:Micah.Villmow@amd.com" class="yiv2054737993cremed">Micah.Villmow@amd.com</a>> wrote:<br>
> As far as I can tell, most basic tools have no test cases, are there examples?<br>
><br>
> test/Other/optimize-options.ll<br>
><br>
><br>
> From: Chandler Carruth [mailto:<a rel="nofollow" ymailto="mailto:chandlerc@google.com" target="_blank" href="mailto:chandlerc@google.com" class="yiv2054737993cremed">chandlerc@google.com</a>]<br>
> Sent: Thursday, September 13, 2012 2:17 PM<br>
> To: Villmow, Micah<br>
> Cc: Jan Sjodin; <a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits@cs.uiuc.edu</a><br>
> Subject: Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.<br>
><br>
> On Thu, Sep 13, 2012 at 2:10 PM, Villmow, Micah <<a rel="nofollow" ymailto="mailto:Micah.Villmow@amd.com" target="_blank" href="mailto:Micah.Villmow@amd.com" class="yiv2054737993cremed">Micah.Villmow@amd.com</a>> wrote:<br>
> LGTM<br>
><br>
> No, this patch isn't ready to go in yet.<br>
><br>
> It has no test case updates, and it doesn't even indent things properly.<br>
><br>
><br>
> From: <a rel="nofollow" ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits-bounces@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a rel="nofollow" ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits-bounces@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Jan Sjodin<br>
> Sent: Thursday, September 13, 2012 1:41 PM<br>
> To: <a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits@cs.uiuc.edu</a><br>
> Subject: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.<br>
><br>
> Hi, I posted in llvm-dev some time back about adding a -without-aliases flag that will not include aliases in the output. Here is the patch. Okay to commit?<br>
><br>
> - Jan<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits@cs.uiuc.edu</a><br>
> <a rel="nofollow" target="_blank" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="yiv2054737993cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv2054737993cremed">llvm-commits@cs.uiuc.edu</a><br>
> <a rel="nofollow" target="_blank" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="yiv2054737993cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div>
</div><br><br> </div> </div> </blockquote></div> </div></body></html>