Added in r164101.<br><br><div class="gmail_quote">On Mon, Sep 17, 2012 at 9:07 PM, Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
When is this going to be added to the coding standards?<br>
<br>
--Sean Silva<br>
<br>
On Mon, Sep 17, 2012 at 11:25 PM, Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<br>
> Author: ctopper<br>
> Date: Mon Sep 17 22:25:49 2012<br>
> New Revision: 164093<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=164093&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=164093&view=rev</a><br>
> Log:<br>
> Mark unimplemented operator new as LLVM_DELETED_FUNCTION.<br>
><br>
> Modified:<br>
> llvm/trunk/include/llvm/Instructions.h<br>
><br>
> Modified: llvm/trunk/include/llvm/Instructions.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Instructions.h?rev=164093&r1=164092&r2=164093&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Instructions.h?rev=164093&r1=164092&r2=164093&view=diff</a><br>
> ==============================================================================<br>
> --- llvm/trunk/include/llvm/Instructions.h (original)<br>
> +++ llvm/trunk/include/llvm/Instructions.h Mon Sep 17 22:25:49 2012<br>
> @@ -255,7 +255,7 @@<br>
> /// StoreInst - an instruction for storing to memory<br>
> ///<br>
> class StoreInst : public Instruction {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> void AssertOK();<br>
> protected:<br>
> virtual StoreInst *clone_impl() const;<br>
> @@ -382,7 +382,7 @@<br>
> /// FenceInst - an instruction for ordering other memory operations<br>
> ///<br>
> class FenceInst : public Instruction {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> void Init(AtomicOrdering Ordering, SynchronizationScope SynchScope);<br>
> protected:<br>
> virtual FenceInst *clone_impl() const;<br>
> @@ -450,7 +450,7 @@<br>
> /// there. Returns the value that was loaded.<br>
> ///<br>
> class AtomicCmpXchgInst : public Instruction {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> void Init(Value *Ptr, Value *Cmp, Value *NewVal,<br>
> AtomicOrdering Ordering, SynchronizationScope SynchScope);<br>
> protected:<br>
> @@ -557,7 +557,7 @@<br>
> /// the old value.<br>
> ///<br>
> class AtomicRMWInst : public Instruction {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> protected:<br>
> virtual AtomicRMWInst *clone_impl() const;<br>
> public:<br>
> @@ -1839,7 +1839,7 @@<br>
> class InsertValueInst : public Instruction {<br>
> SmallVector<unsigned, 4> Indices;<br>
><br>
> - void *operator new(size_t, unsigned); // Do not implement<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> InsertValueInst(const InsertValueInst &IVI);<br>
> void init(Value *Agg, Value *Val, ArrayRef<unsigned> Idxs,<br>
> const Twine &NameStr);<br>
> @@ -1970,7 +1970,7 @@<br>
> // scientist's overactive imagination.<br>
> //<br>
> class PHINode : public Instruction {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> /// ReservedSpace - The number of operands actually allocated. NumOperands is<br>
> /// the number actually in use.<br>
> unsigned ReservedSpace;<br>
> @@ -2178,7 +2178,7 @@<br>
> public:<br>
> enum ClauseType { Catch, Filter };<br>
> private:<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> // Allocate space for exactly zero operands.<br>
> void *operator new(size_t s) {<br>
> return User::operator new(s, 0);<br>
> @@ -2445,7 +2445,7 @@<br>
> /// SwitchInst - Multiway switch<br>
> ///<br>
> class SwitchInst : public TerminatorInst {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> unsigned ReservedSpace;<br>
> // Operands format:<br>
> // Operand[0] = Value to switch on<br>
> @@ -2857,7 +2857,7 @@<br>
> /// IndirectBrInst - Indirect Branch Instruction.<br>
> ///<br>
> class IndirectBrInst : public TerminatorInst {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> unsigned ReservedSpace;<br>
> // Operand[0] = Value to switch on<br>
> // Operand[1] = Default basic block destination<br>
> @@ -3251,7 +3251,7 @@<br>
> /// end of the block cannot be reached.<br>
> ///<br>
> class UnreachableInst : public TerminatorInst {<br>
> - void *operator new(size_t, unsigned); // DO NOT IMPLEMENT<br>
> + void *operator new(size_t, unsigned) LLVM_DELETED_FUNCTION;<br>
> protected:<br>
> virtual UnreachableInst *clone_impl() const;<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><br>-- <br>~Craig<br>