<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt">I cleaned up the patch a bit, plus added a test. I don't think it will take more than a few minutes to review.<br><br>- Jan<br><div><span><br></span></div><div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font face="Arial" size="2"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> Chandler Carruth <chandlerc@google.com><br> <b><span style="font-weight: bold;">To:</span></b> "Villmow, Micah" <Micah.Villmow@amd.com> <br><b><span style="font-weight: bold;">Cc:</span></b> Jan Sjodin <jan_sjodin@yahoo.com>; "llvm-commits@cs.uiuc.edu"
<llvm-commits@cs.uiuc.edu> <br> <b><span style="font-weight: bold;">Sent:</span></b> Thursday, September 13, 2012 5:18 PM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [llvm-commits] Patch to add flag in llvm-extract for including aliases in the extraction.<br> </font> </div> <br>
<div id="yiv260234313"><div class="yiv260234313gmail_extra"><div class="yiv260234313gmail_quote">On Thu, Sep 13, 2012 at 2:10 PM, Villmow, Micah <span dir="ltr"><<a rel="nofollow" ymailto="mailto:Micah.Villmow@amd.com" target="_blank" href="mailto:Micah.Villmow@amd.com" class="yiv260234313cremed">Micah.Villmow@amd.com</a>></span> wrote:<br>
<blockquote class="yiv260234313gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="EN-US">
<div>
<div class="yiv260234313MsoNormal"><span style="font-size:11.0pt;color:#1f497d;">LGTM</span></div></div></div></blockquote><div><br></div><div>I don't have time to do a proper review on this, but it isn't ready to be committed. It has style issues, and no test cases.</div>
<div> </div><blockquote class="yiv260234313gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div lang="EN-US"><div><div class="yiv260234313MsoNormal"><span style="font-size:11.0pt;color:#1f497d;"><u></u><u></u></span></div>
<div class="yiv260234313MsoNormal"><span style="font-size:11.0pt;color:#1f497d;"><u></u> <u></u></span></div>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt;">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in;">
<div class="yiv260234313MsoNormal"><b><span style="font-size:10.0pt;">From:</span></b><span style="font-size:10.0pt;"> <a rel="nofollow" ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits-bounces@cs.uiuc.edu" class="yiv260234313cremed">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a rel="nofollow" ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits-bounces@cs.uiuc.edu" class="yiv260234313cremed">llvm-commits-bounces@cs.uiuc.edu</a>]
<b>On Behalf Of </b>Jan Sjodin<br>
<b>Sent:</b> Thursday, September 13, 2012 1:42 PM<br>
<b>To:</b> <a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv260234313cremed">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> [llvm-commits] Patch to add flag in llvm-extract for including aliases in the extraction.<u></u><u></u></span></div>
</div>
</div><div class="yiv260234313im">
<div class="yiv260234313MsoNormal"><u></u> <u></u></div>
<div>
<div>
<div>
<div>
<div>
<div class="yiv260234313MsoNormal" style="background:white;"><span style="font-size:10.0pt;">Hi, here is a patch for llvm-extract that will include aliases in the extraction when the -with-aliases flag is specified. Okay to commit?<u></u><u></u></span></div>
</div>
<div>
<div class="yiv260234313MsoNormal" style="background:white;"><span style="font-size:10.0pt;"><u></u> <u></u></span></div>
</div>
<div>
<div class="yiv260234313MsoNormal"><span style="font-size:10.0pt;">- Jan<u></u><u></u></span></div>
</div>
<div>
<div class="yiv260234313MsoNormal"><span style="font-size:10.0pt;"><u></u> <u></u></span></div>
</div>
</div>
</div>
</div>
</div>
</div></div>
</div>
</div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a rel="nofollow" ymailto="mailto:llvm-commits@cs.uiuc.edu" target="_blank" href="mailto:llvm-commits@cs.uiuc.edu" class="yiv260234313cremed">llvm-commits@cs.uiuc.edu</a><br>
<a rel="nofollow" target="_blank" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" class="yiv260234313cremed">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</div><br><br> </div> </div> </blockquote></div> </div></body></html>