Glorious and wonderful with one nit:<div><br></div><div><div>+ if (!WithoutAliases)</div><div>+ std::for_each (M->alias_begin(), M->alias_end(),</div><div>+<span class="" style="white-space:pre"> </span> DumpSymbolNameForGlobalValue);</div>
</div><div><br></div><div>No space between 'std::for_each' and the '('. Functions and if statements are different for LLVM's style...</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 14, 2012 at 7:46 AM, Jan Sjodin <span dir="ltr"><<a href="mailto:jan_sjodin@yahoo.com" target="_blank">jan_sjodin@yahoo.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-size:10pt;font-family:arial,helvetica,sans-serif"><div><span>New patch with fixed indentation and test case (includes both with and without the new flag).<br>
</span></div><div style="font-style:normal;font-size:13.3333px;background-color:transparent;font-family:arial,helvetica,sans-serif"><br><span></span></div><div style="font-style:normal;font-size:13.3333px;background-color:transparent;font-family:arial,helvetica,sans-serif">
<span>- Jan<br></span></div><div><br><blockquote style="border-left:2px solid rgb(16,16,255);margin-left:5px;margin-top:5px;padding-left:5px"> <div style="font-family:arial,helvetica,sans-serif;font-size:10pt"> <div style="font-family:times new roman,new york,times,serif;font-size:12pt">
<div dir="ltr"> <font face="Arial"> <hr size="1"> <b><span style="font-weight:bold">From:</span></b> Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>><br> <b><span style="font-weight:bold">To:</span></b> "Villmow, Micah" <<a href="mailto:Micah.Villmow@amd.com" target="_blank">Micah.Villmow@amd.com</a>> <br>
<b><span style="font-weight:bold">Cc:</span></b> Jan Sjodin <<a href="mailto:jan_sjodin@yahoo.com" target="_blank">jan_sjodin@yahoo.com</a>>; "<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>" <<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>> <br>
<b><span style="font-weight:bold">Sent:</span></b> Thursday, September 13, 2012 5:34 PM<div class="im"><br> <b><span style="font-weight:bold">Subject:</span></b> Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.<br>
</div></font> </div><div class="im"> <br>
<div><div><div>On Thu, Sep 13, 2012 at 2:21 PM, Villmow, Micah <span dir="ltr"><<a rel="nofollow" href="mailto:Micah.Villmow@amd.com" target="_blank">Micah.Villmow@amd.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US">
<div>
<div><span style="font-size:11.0pt;color:#1f497d">As far as I can tell, most basic tools have no test cases, are there examples?</span></div></div></div>
</blockquote><div><br></div><div>test/Other/optimize-options.ll</div><div> </div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US">
<div><div><span style="font-size:11.0pt;color:#1f497d"><u></u><u></u></span></div>
<div><span style="font-size:11.0pt;color:#1f497d"><u></u> <u></u></span></div>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<div><b><span style="font-size:10.0pt">From:</span></b><span style="font-size:10.0pt"> Chandler Carruth [mailto:<a rel="nofollow" href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>]
<br>
<b>Sent:</b> Thursday, September 13, 2012 2:17 PM<br>
<b>To:</b> Villmow, Micah<br>
<b>Cc:</b> Jan Sjodin; <a rel="nofollow" href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.<u></u><u></u></span></div>
</div>
</div><div><div>
<div><u></u> <u></u></div>
<div>
<div>
<div>On Thu, Sep 13, 2012 at 2:10 PM, Villmow, Micah <<a rel="nofollow" href="mailto:Micah.Villmow@amd.com" target="_blank">Micah.Villmow@amd.com</a>> wrote:<u></u><u></u></div>
<div>
<div>
<div><span style="font-size:11.0pt;color:#1f497d">LGTM</span><u></u><u></u></div>
</div>
</div>
<div>
<div><u></u> <u></u></div>
</div>
<div>
<div>No, this patch isn't ready to go in yet.<u></u><u></u></div>
</div>
<div>
<div><u></u> <u></u></div>
</div>
<div>
<div>It has no test case updates, and it doesn't even indent things properly.<u></u><u></u></div>
</div>
<div>
<div> <u></u><u></u></div>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<div><span style="font-size:11.0pt;color:#1f497d"> </span><u></u><u></u></div>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<div><b><span style="font-size:10.0pt">From:</span></b><span style="font-size:10.0pt">
<a rel="nofollow" href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:<a rel="nofollow" href="mailto:llvm-commits-bounces@cs.uiuc.edu" target="_blank">llvm-commits-bounces@cs.uiuc.edu</a>]
<b>On Behalf Of </b>Jan Sjodin<br>
<b>Sent:</b> Thursday, September 13, 2012 1:41 PM<br>
<b>To:</b> <a rel="nofollow" href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> [llvm-commits] Patch to add hidden flag to llvm-nm to not emit aliases.</span><u></u><u></u></div>
</div>
</div>
<div>
<div> <u></u><u></u></div>
<div>
<div>
<div style="background:white">
<span style="font-size:10.0pt">Hi, I posted in llvm-dev some time back about adding a -without-aliases flag that will not include aliases in the output. Here is the patch. Okay to commit?</span><u></u><u></u></div>
</div>
<div>
<div style="background:white">
<span style="font-size:10.0pt"> </span><u></u><u></u></div>
</div>
<div>
<div><span style="font-size:10.0pt">- Jan</span><u></u><u></u></div>
</div>
<div>
<div><span style="font-size:10.0pt"> </span><u></u><u></u></div>
</div>
</div>
</div>
</div>
</div>
</div>
<div style="margin-bottom:12.0pt"><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a rel="nofollow" href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a rel="nofollow" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></div>
</blockquote>
</div>
<div><u></u> <u></u></div>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>
</div><br><br> </div></div> </div> </blockquote></div> </div></div></blockquote></div><br></div>