<html><body><div style="color:#000; background-color:#fff; font-family:arial, helvetica, sans-serif;font-size:10pt">LGTM.<div><span></span></div><div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; margin-top: 5px; padding-left: 5px;"> <div style="font-family: arial, helvetica, sans-serif; font-size: 10pt;"> <div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"> <div dir="ltr"> <font size="2" face="Arial"> <hr size="1"> <b><span style="font-weight:bold;">From:</span></b> "Villmow, Micah" <Micah.Villmow@amd.com><br> <b><span style="font-weight: bold;">To:</span></b> "Villmow, Micah" <Micah.Villmow@amd.com>; Duncan Sands <baldrick@free.fr>; "llvm-commits@cs.uiuc.edu" <llvm-commits@cs.uiuc.edu> <br> <b><span style="font-weight: bold;">Sent:</span></b> Tuesday, September 11, 2012 11:14 AM<br> <b><span style="font-weight: bold;">Subject:</span></b> Re: [llvm-commits]
Patch to unify same code in multiple spots<br> </font> </div> <br>
Ping<br><br>From: Villmow, Micah<br>Sent: Thursday, September 06, 2012 9:51 AM<br>To: 'Duncan Sands'; '<a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>'<br>Subject: RE: [llvm-commits] Patch to unify same code in multiple spots<br><br>Here is an updated patch with this feedback.<br><br>From: <a ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a><mailto:<a ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a>> [mailto:<a ymailto="mailto:llvm-commits-bounces@cs.uiuc.edu" href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Duncan Sands<br>Sent: Wednesday, July 25, 2012 1:00 AM<br>To: <a ymailto="mailto:llvm-commits@cs.uiuc.edu"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><mailto:<a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>><br>Subject: Re: [llvm-commits] Patch to unify same code in multiple spots<br><br>This message has been archived. View the original item <http://ausev2.amd.com/EnterpriseVault/ViewMessage.asp?VaultId=12070563DD2F0FE4F9324523BDD9809741110000amdvault.amd.com&SavesetId=201208255869093~201207250801030000~Z~2154F2EFF0A845883AE59EF8A0C8DDB1><br><br>Hi Micah, instead of the prefix/suffix logic, why not do this:<br><br>...<br> } else if (const CallInst *CI = dyn_cast<CallInst>(&I)) {<br> // Print the calling convention being used.<br> if (CI->getCallingConv() != CallingConv::C) // The default<br> PrintCallingConv(F->getCallingConv(), Out);<br>...<br>?<br><br>Ciao,
Duncan.<br>_______________________________________________<br>llvm-commits mailing list<br><a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><mailto:<a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a ymailto="mailto:llvm-commits@cs.uiuc.edu" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br><br> </div> </div> </blockquote></div> </div></body></html>