Let's finish discussing this on the thread with both cfe-commits and llvm-commits. As Eric indicated there, this functionality does not at all seem right for the project. I'll put most of my thoughts on that thread.<div class="gmail_extra">
<br><br><div class="gmail_quote">On Sun, Sep 9, 2012 at 3:42 PM, Ron Lieberman <span dir="ltr"><<a href="mailto:ronl@codeaurora.org" target="_blank">ronl@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Attaching a revised patch which incorporates the suggested change on<br>
spelling the option llvm-vendor.<br>
<div class="im HOEnZb"><br>
<br>
---<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by<br>
The Linux Foundation<br>
<br>
<br>
-----Original Message-----<br>
From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a><br>
</div><div class="HOEnZb"><div class="h5">[mailto:<a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Ron Lieberman<br>
Sent: Sunday, September 09, 2012 7:33 AM<br>
To: 'Duncan Sands'; <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
Subject: Re: [llvm-commits] [PATCH] Provide the capability of defining the<br>
CLANG_VENDOR with configure or cmake.<br>
<br>
Hi Duncan,<br>
Thanks for the suggestion.<br>
<br>
I would be happy to change the option spelling to be<br>
  Cmake:          -DLLVM_VENDOR=<br>
  Configure:    --with-llvm-vendor=<br>
<br>
FYI, the Clang source already contains the support for including the content<br>
of CLANG_VENDOR when Clang is invoked with -v or --version, and when<br>
defining the Macro __VERSION__ The modified patch will spell the option as<br>
llvm_vendor, and will define CLANG_VENDOR which is currently only used<br>
within the file 'tools/clang/lib/Basic/Version.cpp'<br>
<br>
Thanks,<br>
Ron Lieberman<br>
---<br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by<br>
The Linux Foundation<br>
<br>
<br>
-----Original Message-----<br>
From: <a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a><br>
[mailto:<a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a>] On Behalf Of Duncan Sands<br>
Sent: Sunday, September 09, 2012 12:43 AM<br>
To: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
Subject: Re: [llvm-commits] [PATCH] Provide the capability of defining the<br>
CLANG_VENDOR with configure or cmake.<br>
<br>
Hi Ron,<br>
<br>
On 08/09/12 23:10, Ron Lieberman wrote:<br>
> Provide the capability of defining the CLANG_VENDOR with configure or<br>
cmake.<br>
<br>
how about calling it LLVM_VENDOR instead?  After all, it may be useful for<br>
all kinds of projects using LLVM, not just clang.  And I don't much like<br>
putting clang specific stuff into LLVM if it can be avoided - seems like a<br>
layering violation.<br>
<br>
Ciao, Duncan.<br>
<br>
><br>
> Default for the new configure options:<br>
><br>
>    --with-clang-vendor defaults to null.<br>
><br>
> The vendor name is configured using the following option<br>
><br>
>    --with-clang-vendor="INTLWICKET " \<br>
><br>
> Examples:<br>
><br>
> $ clang -v<br>
><br>
> INTLWICKET clang version 3.2  (based on LLVM 3.2svn)<br>
><br>
> Target: x86_64-unknown-linux-gnu<br>
><br>
> Thread model: posix<br>
><br>
> The __VERSION__ macro becomes:<br>
><br>
> define __VERSION__ "4.2.1 Compatible INTLWICKET Clang 3.2 "<br>
><br>
> Testing:<br>
><br>
> cmake<br>
><br>
> cmake -DCLANG_VENDOR=<br>
><br>
> cmake -DCLANG_VENDOR="INTLWICKET "<br>
><br>
> configure<br>
><br>
> configure --with-clang-vendor=<br>
><br>
> configure --with-clang-vendor="INTLWICKET "<br>
><br>
> Ron Lieberman<br>
><br>
> ---<br>
><br>
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,<br>
> hosted by The Linux Foundation<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>