<html><head></head><body bgcolor="#FFFFFF"><div>It does? That wasn't working for me but let me double check the version of Clang I was using. Either way I'll back this out.<br><br><div> - Daniel</div><div><br></div>
</div><div><br>On Sep 7, 2012, at 14:18, Richard Smith <<a href="mailto:richard@metafoo.co.uk">richard@metafoo.co.uk</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>On Fri, Sep 7, 2012 at 1:23 PM, Daniel Dunbar <span dir="ltr"><<a href="mailto:daniel@zuster.org" target="_blank">daniel@zuster.org</a>></span> wrote:<br>
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Friday, September 7, 2012, Chandler Carruth wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_extra"><div class="gmail_quote">
On Fri, Sep 7, 2012 at 3:57 PM, Daniel Dunbar <span dir="ltr"><<a>daniel@zuster.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ddunbar<br>
Date: Fri Sep 7 14:57:20 2012<br>
New Revision: 163411<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=163411&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=163411&view=rev</a><br>
Log:<br>
[asan] Suppress some bogus -Winvalid-noreturn diagnostics.<br></blockquote><div><br></div><div>Please no. This is not the right way to suppress these. This code is hard enough to read w/o adding pragmas to the mix.</div>
<div><br></div><div>If this warning is bogus, we should fix the warning.</div></div></div></blockquote><div><br></div></div><div>The warning is not bogus, but I don't think we are going to fix Clang to detect the situation where the RAII object destructor causes a noreturn.</div>
</blockquote><div><br></div><div>We don't even *need* to fix Clang. It already handles that situation if you mark the destructor as noreturn.</div></div>
</div></blockquote></body></html>