<br><br><div class="gmail_quote">On Fri, Aug 31, 2012 at 9:22 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On Fri, Aug 31, 2012 at 10:12 AM, Alexey Samsonov <<a href="mailto:samsonov@google.com">samsonov@google.com</a>> wrote:<br>
><br>
><br>
> On Fri, Aug 31, 2012 at 9:06 PM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
>><br>
>> On Fri, Aug 31, 2012 at 4:43 AM, Alexey Samsonov <<a href="mailto:samsonov@google.com">samsonov@google.com</a>><br>
>> wrote:<br>
>> > Author: samsonov<br>
>> > Date: Fri Aug 31 06:43:01 2012<br>
>> > New Revision: 162990<br>
>> ><br>
>> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=162990&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=162990&view=rev</a><br>
>> > Log:<br>
>> > [Sanitizer] fix overloaded operator error<br>
>> ><br>
>> > Modified:<br>
>> > compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer.cc<br>
>> > compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_linux.cc<br>
>> ><br>
>> > Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer.cc<br>
>> > URL:<br>
>> > <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer.cc?rev=162990&r1=162989&r2=162990&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer.cc?rev=162990&r1=162989&r2=162990&view=diff</a><br>
>> ><br>
>> > ==============================================================================<br>
>> > --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer.cc<br>
>> > (original)<br>
>> > +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer.cc Fri<br>
>> > Aug 31 06:43:01 2012<br>
>> > @@ -255,7 +255,7 @@<br>
>> > }<br>
>> ><br>
>> > static const uptr kMaxNumberOfModuleContexts = 4096;<br>
>> > - LoadedModule *modules_; // Array of module descriptions is leaked.<br>
>> > + LoadedModule *modules_; // Array of module descriptions is leaked.<br>
>> > uptr n_modules_;<br>
>> ><br>
>> > ExternalSymbolizer *external_symbolizer_; // Leaked.<br>
>> ><br>
>> > Modified:<br>
>> > compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_linux.cc<br>
>> > URL:<br>
>> > <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_linux.cc?rev=162990&r1=162989&r2=162990&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_linux.cc?rev=162990&r1=162989&r2=162990&view=diff</a><br>
>> ><br>
>> > ==============================================================================<br>
>> > --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_linux.cc<br>
>> > (original)<br>
>> > +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_symbolizer_linux.cc<br>
>> > Fri Aug 31 06:43:01 2012<br>
>> > @@ -122,7 +122,7 @@<br>
>> > if (data->current_n == data->max_n)<br>
>> > return 0;<br>
>> > InternalScopedBuffer<char> module_name(kMaxPathLength);<br>
>> > - module_name[0] = '\0';<br>
>> > + module_name.data()[0] = '\0';<br>
>><br>
>> What's the purpose of this change?<br>
>><br>
>> From what I can see, these two constructs look equivalent, given that<br>
>> the op[] and data() members are defined as:<br>
>><br>
>> T &operator[](uptr i) { return ptr_[i]; }<br>
>> T *data() { return ptr_; }<br>
><br>
><br>
> ../sanitizer_common/sanitizer_symbolizer_linux.cc:125:14: error: use of<br>
> overloaded operator '[]' is ambiguous (with operand types<br>
> 'InternalScopedBuffer<char>' and 'int')<br>
> module_name[0] = '\0';<br>
> ~~~~~~~~~~~^~<br>
> ../sanitizer_common/sanitizer_common.h:71:6: note: candidate function<br>
> T &operator[](uptr i) { return ptr_[i]; }<br>
> ^<br>
> ../sanitizer_common/sanitizer_symbolizer_linux.cc:125:14: note: built-in<br>
> candidate operator[](char *, int)<br>
> module_name[0] = '\0';<br>
<br>
</div></div>Ah, so the implicit conversion to T* is causing this? (is that<br>
implicit conversion really the best idea? the "data()" member function<br>
seems like it might be the better option - implicit conversions can<br>
get a bit surprising, as is the case here).<br></blockquote><div><br></div><div>I think you're right and it's cleaner to remove implicit conversion here (submitted).</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Alternatively you could use 0ul, probably. Though both versions seem a<br>
bit subtle when a reader comes back & wonders why it was written that<br>
way.<br>
<br>
Anyway, just a thought.<br></blockquote><div><br></div><div>Thanks!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888">- David<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
>><br>
>><br>
>> > if (data->current_n == 0) {<br>
>> > // First module is the binary itself.<br>
>> > uptr module_name_len = readlink("/proc/self/exe",<br>
>> > @@ -133,7 +133,7 @@<br>
>> > } else if (info->dlpi_name) {<br>
>> > internal_strncpy(module_name, info->dlpi_name, module_name.size());<br>
>> > }<br>
>> > - if (module_name[0] == '\0')<br>
>> > + if (module_name.data()[0] == '\0')<br>
>> > return 0;<br>
>> > void *mem = &data->modules[data->current_n];<br>
>> > LoadedModule *cur_module = new(mem) LoadedModule(module_name,<br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > llvm-commits mailing list<br>
>> > <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
><br>
><br>
> --<br>
> Alexey Samsonov, MSK<br>
><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div><br>