LGTM<div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 28, 2012 at 5:07 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@apple.com" target="_blank">echristo@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On Aug 28, 2012, at 9:25 AM, Brad Smith <<a href="mailto:brad@comstyle.com">brad@comstyle.com</a>> wrote:<br>
<br>
> On Fri, Aug 24, 2012 at 06:50:31AM -0400, Brad Smith wrote:<br>
>> On Sat, Aug 18, 2012 at 03:03:37AM -0400, Brad Smith wrote:<br>
>>> The attached diff for the CMake build infrastructure fixes<br>
>>> the check for pthead_mutex_lock. CMake is attempting to build<br>
>>> a binary to check for the existence of the symbol but not<br>
>>> linking in libpthread.<br>
>>><br>
>>> /usr/bin/cc   -O2 -pipe        CMakeFiles/cmTryCompileExec2801244708.dir/CheckSymbolExists.c.o  -o cmTryCompileExec2801244708  -lm -Wl,-rpath-link,/usr/X11R6/lib:/us<br>
>>> r/local/lib<br>
>>> CMakeFiles/cmTryCompileExec2801244708.dir/CheckSymbolExists.c.o(.text+0x6): In function `main':<br>
>>> : undefined reference to `pthread_mutex_lock'<br>
>>> collect2: ld returned 1 exit status<br>
>><br>
>> ping.<br>
><br>
> Anyone?<br>
><br>
<br>
</div>Looks reasonable, I've poked Chandler about it since cmake is his baby.<br>
<span class="HOEnZb"><font color="#888888"><br>
-eric<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
>>> Index: cmake/config-ix.cmake<br>
>>> ===================================================================<br>
>>> --- cmake/config-ix.cmake   (revision 161828)<br>
>>> +++ cmake/config-ix.cmake   (working copy)<br>
>>> @@ -87,6 +87,7 @@<br>
>>>   check_library_exists(pthread pthread_create "" HAVE_LIBPTHREAD)<br>
>>>   check_library_exists(pthread pthread_getspecific "" HAVE_PTHREAD_GETSPECIFIC)<br>
>>>   check_library_exists(pthread pthread_rwlock_init "" HAVE_PTHREAD_RWLOCK_INIT)<br>
>>> +  check_library_exists(pthread pthread_mutex_lock "" HAVE_PTHREAD_MUTEX_LOCK)<br>
>>>   check_library_exists(dl dlopen "" HAVE_LIBDL)<br>
>>> endif()<br>
>>><br>
>>> @@ -134,9 +135,6 @@<br>
>>> check_symbol_exists(strcmp string.h HAVE_STRCMP)<br>
>>> check_symbol_exists(strdup string.h HAVE_STRDUP)<br>
>>> check_symbol_exists(strrchr string.h HAVE_STRRCHR)<br>
>>> -if( NOT PURE_WINDOWS )<br>
>>> -  check_symbol_exists(pthread_mutex_lock pthread.h HAVE_PTHREAD_MUTEX_LOCK)<br>
>>> -endif()<br>
>>> check_symbol_exists(sbrk unistd.h HAVE_SBRK)<br>
>>> check_symbol_exists(srand48 stdlib.h HAVE_RAND48_SRAND48)<br>
>>> if( HAVE_RAND48_SRAND48 )<br>
>><br>
>>> _______________________________________________<br>
>>> llvm-commits mailing list<br>
>>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>><br>
>><br>
>> --<br>
>> This message has been scanned for viruses and<br>
>> dangerous content by MailScanner, and is<br>
>> believed to be clean.<br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
> --<br>
> This message has been scanned for viruses and<br>
> dangerous content by MailScanner, and is<br>
> believed to be clean.<br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</div></div></blockquote></div><br></div>