<br><br><div class="gmail_quote">On 27 August 2012 15:11, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span> wrote:<br><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
Fixed in r162664. You could reproduce the failure to add to it locally;<br>
<br>
-mtriple=i686-unknown-unknown<br>
-mtriple=x86_64-mingw32<br></blockquote><div> </div><div>I can repro it now. Thanks for fixing it. </div><div> </div><div>-Anitha</div><div> <br>
2012/8/27 Anitha Boyapati <<a href="mailto:anitha.boyapati@gmail.com">anitha.boyapati@gmail.com</a>>:<br></div><blockquote style="margin:0px 0px 0px 0.8ex;padding-left:1ex;border-left-color:rgb(204,204,204);border-left-width:1px;border-left-style:solid" class="gmail_quote">
<div class="HOEnZb"><div class="h5">><br>
><br>
> On 27 August 2012 12:39, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<br>
>><br>
>> FYI, it seems like a build bot failed:<br>
>><br>
>> <a href="http://bb.pgr.jp/builders/cmake-clang-i686-mingw32/builds/15" target="_blank">http://bb.pgr.jp/builders/cmake-clang-i686-mingw32/builds/15</a><br>
><br>
><br>
> Strange. The test fma_patterns.ll passes for me with rev 162655.<br>
><br>
> build/test> clang -v<br>
> clang version 3.2 (trunk 162661) (llvm/trunk 162654:162655M)<br>
> Target: x86_64-unknown-linux-gnu<br>
> Thread model: posix<br>
> build/test> llvm-lit CodeGen/X86/fma_patterns.ll<br>
> -- Testing: 1 tests, 1 threads --<br>
> PASS: LLVM :: CodeGen/X86/fma_patterns.ll (1 of 1)<br>
> Testing Time: 0.08s<br>
> Expected Passes : 1<br>
><br>
> Moreover, for that particular function "def _test_x86_fnmadd_ss" ( reported<br>
> as failed), I could see that the generated assembly is same as what is<br>
> expected in fma_patterns.ll<br>
><br>
>>>>>>>>>><br>
> build/test> llc -mcpu=bdver2 -mattr=-fma4 -fp-contract=fast<br>
> test_x86_fnmadd.ll<br>
> build/test> more test_x86_fnmadd.s<br>
> .file "test_x86_fnmadd.ll"<br>
> .text<br>
> .globl test_x86_fnmadd_ss<br>
> .align 16, 0x90<br>
> .type test_x86_fnmadd_ss,@function<br>
> test_x86_fnmadd_ss: # @test_x86_fnmadd_ss<br>
> .cfi_startproc<br>
> # BB#0:<br>
> vfnmadd213ss %xmm2, %xmm0, %xmm1<br>
> vmovaps %xmm1, %xmm0<br>
> ret<br>
> .Ltmp0:<br>
> .size test_x86_fnmadd_ss, .Ltmp0-test_x86_fnmadd_ss<br>
> .cfi_endproc<br>
> <<<<<<<br>
><br>
> Looks like given report has memory form of fma. Am I missing something here?<br>
> Can mingw32 make a difference?<br>
><br>
> -Anitha<br>
>><br>
>><br>
>><br>
>> On Sun, Aug 26, 2012 at 11:59 PM, Anitha Boyapati<br>
>> <<a href="mailto:anitha.boyapati@gmail.com">anitha.boyapati@gmail.com</a>> wrote:<br>
>>><br>
>>> Author: anithab<br>
>>> Date: Mon Aug 27 01:59:01 2012<br>
>>> New Revision: 162655<br>
>>><br>
>>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=162655&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=162655&view=rev</a><br>
>>> Log:<br>
>>><br>
>>> FMA3 tests on bdver2 target for changes made in rev 162012. Also made<br>
>>> corresponding changes to existing tests for darwin triple to ensure that<br>
>>> same pattern is tested for bdver2 target.<br>
>>><br>
>>><br>
>>> Modified:<br>
>>> llvm/trunk/test/CodeGen/X86/fma.ll<br>
>>> llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll<br>
>>> llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll<br>
>>> llvm/trunk/test/CodeGen/X86/fma_patterns.ll<br>
>>><br>
>>> Modified: llvm/trunk/test/CodeGen/X86/fma.ll<br>
>>> URL:<br>
>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma.ll?rev=162655&r1=162654&r2=162655&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma.ll?rev=162655&r1=162654&r2=162655&view=diff</a><br>
>>><br>
>>> ==============================================================================<br>
>>> --- llvm/trunk/test/CodeGen/X86/fma.ll (original)<br>
>>> +++ llvm/trunk/test/CodeGen/X86/fma.ll Mon Aug 27 01:59:01 2012<br>
>>> @@ -1,11 +1,13 @@<br>
>>> -; RUN: llc < %s -mtriple=i386-apple-darwin10 -mattr=+fma | FileCheck<br>
>>> %s --check-prefix=CHECK-FMA-INST<br>
>>> -; RUN: llc < %s -mtriple=i386-apple-darwin10 | FileCheck<br>
>>> %s --check-prefix=CHECK-FMA-CALL<br>
>>> -; RUN: llc < %s -mtriple=x86_64-apple-darwin10 -mattr=+fma | FileCheck<br>
>>> %s --check-prefix=CHECK-FMA-INST<br>
>>> -; RUN: llc < %s -mtriple=x86_64-apple-darwin10 | FileCheck<br>
>>> %s --check-prefix=CHECK-FMA-CALL<br>
>>> +; RUN: llc < %s -mtriple=i386-apple-darwin10 -mattr=+fma,-fma4 |<br>
>>> FileCheck %s --check-prefix=CHECK-FMA-INST<br>
>>> +; RUN: llc < %s -mtriple=i386-apple-darwin10 -mattr=-fma,-fma4 |<br>
>>> FileCheck %s --check-prefix=CHECK-FMA-CALL<br>
>>> +; RUN: llc < %s -mtriple=x86_64-apple-darwin10 -mattr=+fma,-fma4 |<br>
>>> FileCheck %s --check-prefix=CHECK-FMA-INST<br>
>>> +; RUN: llc < %s -mtriple=x86_64-apple-darwin10 -mattr=-fma,-fma4 |<br>
>>> FileCheck %s --check-prefix=CHECK-FMA-CALL<br>
>>> +; RUN: llc < %s -mcpu=bdver2 -mattr=-fma4 | FileCheck %s<br>
>>> --check-prefix=CHECK-FMA-INST<br>
>>> +; RUN: llc < %s -mcpu=bdver2 -mattr=-fma,-fma4 | FileCheck %s<br>
>>> --check-prefix=CHECK-FMA-CALL<br>
>>><br>
>>> ; CHECK: test_f32<br>
>>> ; CHECK-FMA-INST: vfmadd213ss<br>
>>> -; CHECK-FMA-CALL: _fmaf<br>
>>> +; CHECK-FMA-CALL: fmaf<br>
>>><br>
>>> define float @test_f32(float %a, float %b, float %c) nounwind readnone<br>
>>> ssp {<br>
>>> entry:<br>
>>> @@ -15,7 +17,7 @@<br>
>>><br>
>>> ; CHECK: test_f64<br>
>>> ; CHECK-FMA-INST: vfmadd213sd<br>
>>> -; CHECK-FMA-CALL: _fma<br>
>>> +; CHECK-FMA-CALL: fma<br>
>>><br>
>>> define double @test_f64(double %a, double %b, double %c) nounwind<br>
>>> readnone ssp {<br>
>>> entry:<br>
>>> @@ -24,7 +26,7 @@<br>
>>> }<br>
>>><br>
>>> ; CHECK: test_f80<br>
>>> -; CHECK: _fmal<br>
>>> +; CHECK: fmal<br>
>>><br>
>>> define x86_fp80 @test_f80(x86_fp80 %a, x86_fp80 %b, x86_fp80 %c)<br>
>>> nounwind readnone ssp {<br>
>>> entry:<br>
>>><br>
>>> Modified: llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll<br>
>>> URL:<br>
>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll?rev=162655&r1=162654&r2=162655&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll?rev=162655&r1=162654&r2=162655&view=diff</a><br>
>>><br>
>>> ==============================================================================<br>
>>> --- llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll (original)<br>
>>> +++ llvm/trunk/test/CodeGen/X86/fma3-intrinsics.ll Mon Aug 27 01:59:01<br>
>>> 2012<br>
>>> @@ -1,5 +1,6 @@<br>
>>> ; RUN: llc < %s -mtriple=x86_64-pc-win32 -mcpu=core-avx2 | FileCheck %s<br>
>>> ; RUN: llc < %s -mtriple=x86_64-pc-win32 -mattr=+fma,+fma4 | FileCheck<br>
>>> %s<br>
>>> +; RUN: llc < %s -mcpu=bdver2 -mtriple=x86_64-pc-win32 -mattr=-fma4 |<br>
>>> FileCheck %s<br>
>>><br>
>>> define <4 x float> @test_x86_fmadd_ss(<4 x float> %a0, <4 x float> %a1,<br>
>>> <4 x float> %a2) {<br>
>>> ; CHECK: fmadd213ss %xmm<br>
>>><br>
>>> Modified: llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll<br>
>>> URL:<br>
>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll?rev=162655&r1=162654&r2=162655&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll?rev=162655&r1=162654&r2=162655&view=diff</a><br>
>>><br>
>>> ==============================================================================<br>
>>> --- llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll (original)<br>
>>> +++ llvm/trunk/test/CodeGen/X86/fma4-intrinsics-x86_64.ll Mon Aug 27<br>
>>> 01:59:01 2012<br>
>>> @@ -1,4 +1,5 @@<br>
>>> ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -march=x86-64<br>
>>> -mattr=+avx,+fma4 | FileCheck %s<br>
>>> +; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mcpu=bdver2<br>
>>> -mattr=+avx,-fma | FileCheck %s<br>
>>><br>
>>> ; VFMADD<br>
>>> define < 4 x float > @test_x86_fma_vfmadd_ss(< 4 x float > %a0, < 4 x<br>
>>> float > %a1, < 4 x float > %a2) {<br>
>>><br>
>>> Modified: llvm/trunk/test/CodeGen/X86/fma_patterns.ll<br>
>>> URL:<br>
>>> <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma_patterns.ll?rev=162655&r1=162654&r2=162655&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/fma_patterns.ll?rev=162655&r1=162654&r2=162655&view=diff</a><br>
>>><br>
>>> ==============================================================================<br>
>>> --- llvm/trunk/test/CodeGen/X86/fma_patterns.ll (original)<br>
>>> +++ llvm/trunk/test/CodeGen/X86/fma_patterns.ll Mon Aug 27 01:59:01 2012<br>
>>> @@ -1,4 +1,5 @@<br>
>>> ; RUN: llc < %s -mtriple=x86_64-apple-darwin -mcpu=core-avx2<br>
>>> -mattr=avx2,+fma -fp-contract=fast | FileCheck %s<br>
>>> +; RUN: llc < %s -mcpu=bdver2 -mattr=-fma4 -fp-contract=fast | FileCheck<br>
>>> %s<br>
>>><br>
>>> ; CHECK: test_x86_fmadd_ps<br>
>>> ; CHECK: vfmadd213ps %xmm2, %xmm0, %xmm1<br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> llvm-commits mailing list<br>
>>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>><br>
>><br>
><br>
><br>
><br>
> --<br>
> Anitha<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><i style="font-family:times new roman,serif"><b> Anitha</b></i><br><br>