<div class="gmail_extra"><div class="gmail_quote">On Fri, Aug 24, 2012 at 12:17 PM,  <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
LGTM++<br>
My fault that I left the FIXME unfixed.<br>
<br>
<br>
<a href="http://codereview.appspot.com/6478053/diff/1/sanitizer_common/sanitizer_allocator64.h" target="_blank">http://codereview.appspot.com/<u></u>6478053/diff/1/sanitizer_<u></u>common/sanitizer_allocator64.h</a><br>
File sanitizer_common/sanitizer_<u></u>allocator64.h (right):<br>
<br>
<a href="http://codereview.appspot.com/6478053/diff/1/sanitizer_common/sanitizer_allocator64.h#newcode151" target="_blank">http://codereview.appspot.com/<u></u>6478053/diff/1/sanitizer_<u></u>common/sanitizer_allocator64.<u></u>h#newcode151</a><br>

sanitizer_common/sanitizer_<u></u>allocator64.h:151: for (uptr i = 0; i < count<br>
&& !region->free_list.empty(); i++) {<br>
region->free list has a size, so you don't need to empty() on every<br>
iteration.<br>
Also, if region->free_list has less than count chunks we want to<br>
preserve the old behavior.<br>
This can be done in a separate CL if you wish<br></blockquote><div><br></div><div>Done in r162561.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
<a href="http://codereview.appspot.com/6478053/diff/1/sanitizer_common/tests/sanitizer_allocator64_test.cc" target="_blank">http://codereview.appspot.com/<u></u>6478053/diff/1/sanitizer_<u></u>common/tests/sanitizer_<u></u>allocator64_test.cc</a><br>

File sanitizer_common/tests/<u></u>sanitizer_allocator64_test.cc (right):<br>
<br>
<a href="http://codereview.appspot.com/6478053/diff/1/sanitizer_common/tests/sanitizer_allocator64_test.cc#newcode31" target="_blank">http://codereview.appspot.com/<u></u>6478053/diff/1/sanitizer_<u></u>common/tests/sanitizer_<u></u>allocator64_test.cc#newcode31</a><br>

sanitizer_common/tests/<u></u>sanitizer_allocator64_test.cc:<u></u>31:<br>
SCMap::MaxCached(i));<br>
please don't remove the old debug code, just append the new one.<br>
<br>
<a href="http://codereview.appspot.com/6478053/" target="_blank">http://codereview.appspot.com/<u></u>6478053/</a><br>
</blockquote></div><br></div>