<br><br><div class="gmail_quote">On Tue, Aug 21, 2012 at 1:03 PM, Evgeniy Stepanov <span dir="ltr"><<a href="mailto:eugenis@google.com" target="_blank">eugenis@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br><div class="gmail_extra"><br><br><div class="gmail_quote"><div class="im">On Tue, Aug 21, 2012 at 10:14 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Dan, <div><br></div><div>I am very glad that you doing this! </div><div>However, adding a new platform which my team is not supporting will cause some amount of pain. </div>
<div>Do you plan to have a public buildbot for LLVM+asan on FreeBSD? </div>
<div><br></div><div>While my team is the only party maintaining asan, our private bots work fine,</div><div>but once others start adding more platforms to asan we will need public bots. </div><div>Chandler, all, is there any chance to have public bots for asan (Linux, Mac, Android, Win32, FreeBSD) somewhere? </div>
</blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br></div><div><br></div><div>+#if !defined(__linux__) && !defined(__APPLE__) && !defined(_WIN32) && !defined(__FreeBSD__) </div>
<div>Please honor 80-chars-per-line rule</div><div><br></div><div><div>- return syscall(__NR_munmap, addr, length); </div>
<div>+ return syscall(SYS_munmap, addr, length); </div></div><div><br></div><div>My recollection is that this will not work for Android. </div></blockquote><div><br></div></div><div>Yes, Android only has _NR_*, and not SYS_*.</div>
<div class="im">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>Evgeniy? </div><div><br></div><div>Maybe it makes sense to create sanitizer_common/sanitizer_bsd.cc (or sanitizer_freebsd.cc)?</div>
<div>OTOH, most of the code will be the same...</div></blockquote><div><br></div></div><div>I guess the difference from linux will be minimal. Better add a few #ifdefs.</div></div></div></blockquote><div><br></div><div>Maybe define some macro like</div>
<div> SYSCALL_NAME(name) which will expand into either __NR_#name or SYS_#name?</div><div><br></div><div><br></div><div><br></div><div>--kcc </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra"><div class="gmail_quote"><div class="im"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div> </div><div><br></div><div>--kcc </div><div><br><br><div class="gmail_quote">On Tue, Aug 21, 2012 at 8:54 AM, Dan McGregor <span dir="ltr"><<a href="mailto:danismostlikely@gmail.com" target="_blank">danismostlikely@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hello,<div><br></div><div>Over the last few days I've been working on getting ASan working on FreeBSD. My ongoing work can be seen at <a href="https://github.com/dannomac/compiler-rt/tree/freebsd" target="_blank">https://github.com/dannomac/compiler-rt/tree/freebsd</a>. Here is a patch to get ASan building on FreeBSD 10, though i386 on amd64 builds currently don't work amd64 builds do.</div>
<span><font color="#888888">
<div><br></div><div>Dan</div>
</font></span><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>
</blockquote></div></div><br></div>
</blockquote></div><br>