<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Jush,</div><div>Based on your description this patch has two fixes. I realize these are very small changes, but can you please split this into two patches?</div><div><br></div><div>Also</div><div><br></div><div><div>+ if (!Subtarget->isAAPCS_ABI())</div><div>+ return (Return ? RetCC_ARM_APCS : CC_ARM_APCS);</div><div>+ else if (Subtarget->hasVFP2() &&</div><div>+ TM.Options.FloatABIType == FloatABI::Hard && !isVarArg)</div><div>+ return (Return ? RetCC_ARM_AAPCS_VFP: CC_ARM_AAPCS_VFP);</div></div><div><br></div><div>No need for the 'else' in the 'else if' since the previous statement was a return.</div><div><br></div><div> Chad</div><br><div><div>On Aug 9, 2012, at 4:53 AM, Jush Lu wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><b id="internal-source-marker_0.20839887741021812" style="font-family:'LiHei Pro';font-size:medium;font-weight:normal"><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Hi,</span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">This patch adds support for fast calling convention, and this patch is almost same as r117119, I just copied a piece of code from CCAssignFnForNode which is in lib/Target/ARM/ARMISelLowering.cpp</span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Currently ARMFastISel handles fastcc for caller side by simply falling through to other calling conventions such as CC_ARM_AAPCS, but the callee with fastcc always uses CC_ARM_AAPCS_VFP calling convention if VFP2 is available. This inconsistency of calling conventions will make problems, and this patch will fix it as well.</span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Please review this patch, thanks.</span><br>
<span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap"></span><br><span style="font-size:15px;font-family:Arial;vertical-align:baseline;white-space:pre-wrap">Jush</span></b>
<span><fast-isel-fastcc.patch></span></blockquote></div><br></body></html>