<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><base href="x-msg://3403/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">It seems fine to me.<div><br></div><div>Evan</div><div><br><div><div>On Aug 8, 2012, at 6:08 AM, "Liao, Michael" <<a href="mailto:michael.liao@intel.com">michael.liao@intel.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div lang="EN-US" link="blue" vlink="purple" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div class="WordSection1" style="page: WordSection1; "><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Hi<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Is this revised patch look ok?<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Yours<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">- Michael<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div><div style="border-style: solid none none; border-top-width: 1pt; border-top-color: rgb(181, 196, 223); padding: 3pt 0in 0in; "><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><b><span style="font-size: 10pt; font-family: Tahoma, sans-serif; ">From:</span></b><span style="font-size: 10pt; font-family: Tahoma, sans-serif; "><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits-bounces@cs.uiuc.edu">llvm-commits-bounces@cs.uiuc.edu</a> [mailto:llvm-<a href="mailto:commits-bounces@cs.uiuc.edu">commits-bounces@cs.uiuc.edu</a>]<span class="Apple-converted-space"> </span><b>On Behalf Of<span class="Apple-converted-space"> </span></b>Liao, Michael<br><b>Sent:</b><span class="Apple-converted-space"> </span>Tuesday, August 07, 2012 11:17 AM<br><b>To:</b><span class="Apple-converted-space"> </span>Craig Topper<br><b>Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><b>Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-commits] [PATCH 1/2] Fix PR12312<o:p></o:p></span></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><o:p> </o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Hi<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Please review the revised patch replacing the loop on zext checking to a simple check.<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">Yours<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); ">- Michael<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><span style="font-size: 11pt; font-family: Calibri, sans-serif; color: rgb(31, 73, 125); "> </span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><b><span style="font-size: 10pt; font-family: Tahoma, sans-serif; ">From:</span></b><span style="font-size: 10pt; font-family: Tahoma, sans-serif; "><span class="Apple-converted-space"> </span>Craig Topper<span class="Apple-converted-space"> </span><a href="mailto:[mailto:craig.topper@gmail.com]" style="color: purple; text-decoration: underline; ">[mailto:craig.topper@gmail.com]</a><span class="Apple-converted-space"> </span><br><b>Sent:</b><span class="Apple-converted-space"> </span>Tuesday, August 07, 2012 9:15 AM<br><b>To:</b><span class="Apple-converted-space"> </span>Liao, Michael<br><b>Cc:</b><span class="Apple-converted-space"> </span>Evan Cheng;<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">llvm-commits@cs.uiuc.edu</a><br><b>Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-commits] [PATCH 1/2] Fix PR12312<o:p></o:p></span></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><o:p> </o:p></div><p class="MsoNormal" style="margin: 0in 0in 12pt; font-size: 12pt; font-family: 'Times New Roman', serif; ">I think his point was that DAG combine wouldn't have allowed ZERO_EXT to be nested so that should only be one of them. Which means you shouldn't need a loop.<o:p></o:p></p><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; ">On Tue, Aug 7, 2012 at 6:05 AM, Liao, Michael <<a href="mailto:michael.liao@intel.com" target="_blank" style="color: purple; text-decoration: underline; ">michael.liao@intel.com</a>> wrote:<o:p></o:p></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; ">Most flag-generating intrinsics returns i32 instead of i8 and do zero-extend after SETcc. We need skip them.<br><br>Yours<br><span class="hoenzb"><span style="color: rgb(136, 136, 136); ">- Michael</span></span><o:p></o:p></div><div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><br>-----Original Message-----<br>From: Evan Cheng [mailto:<a href="mailto:evan.cheng@apple.com" style="color: purple; text-decoration: underline; ">evan.cheng@apple.com</a>]<br>Sent: Monday, August 06, 2012 1:02 PM<br>To: Liao, Michael<br>Cc:<span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">llvm-commits@cs.uiuc.edu</a><br>Subject: Re: [llvm-commits] [PATCH 1/2] Fix PR12312<br><br>The patch looks fine. But this part looks funny to me:<br><br>+ // Skip all 'zext' nodes.<br>+ while (SetCC.getOpcode() == ISD::ZERO_EXTEND)<br>+ SetCC = SetCC.getOperand(0);<br>+<br><br>Why is a loop needed?<br><br>Evan<br><br>On Aug 3, 2012, at 12:53 PM, Michael Liao <<a href="mailto:michael.liao@intel.com" style="color: purple; text-decoration: underline; ">michael.liao@intel.com</a>> wrote:<br><br>> Hi<br>><br>> Just ping after 2 days. Does this patch looks good?<br>><br>> Yours<br>> - Michael<br>><br>> On Wed, 2012-08-01 at 12:46 -0700, Michael Liao wrote:<br>>> Hi<br>>><br>>> This patch is to fix<span class="Apple-converted-space"> </span><a href="http://llvm.org/bugs/show_bug.cgi?id=12312" target="_blank" style="color: purple; text-decoration: underline; ">http://llvm.org/bugs/show_bug.cgi?id=12312</a>,<br>>> where a special use of i128 needs efficient code generation with<br>>> PTEST from SSE4.1.<br>>><br>>> To fix this issue, 2 patches are developed. The first part is to<br>>> simplify a common pattern introduced by most intrinsics generating<br>>> boolean values. Their boolean result are re-evaluated again to get<br>>> EFLAGS updated for BRCOND/CMOV or even SETCC again to consume. The<br>>> attached patch adds a X86-specific DAG optimzation to simplify this<br>>> common pattern by directly consuming the EFLAGS updated from the<br>>> original intrinsics, e.g. llvm.x86.sse41.ptest, if we found that<br>>> integer result is checked as a boolean value.<br>>><br>>> Yours<br>>> - Michael<br>>><br>>><br>>><br>>> _______________________________________________<br>>> llvm-commits mailing list<br>>><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">llvm-commits@cs.uiuc.edu</a><br>>><span class="Apple-converted-space"> </span><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" style="color: purple; text-decoration: underline; ">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>><br>><br>> _______________________________________________<br>> llvm-commits mailing list<br>><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">llvm-commits@cs.uiuc.edu</a><br>><span class="Apple-converted-space"> </span><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" style="color: purple; text-decoration: underline; ">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" style="color: purple; text-decoration: underline; ">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank" style="color: purple; text-decoration: underline; ">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></div></div></div><div style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: 'Times New Roman', serif; "><br><br clear="all"><br>--<span class="Apple-converted-space"> </span><br>~Craig</div></div></div></blockquote></div><br></div></body></html>