<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Aug 2, 2012, at 8:27 AM, Alexey Samsonov <<a href="mailto:samsonov@google.com">samsonov@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Thu, Aug 2, 2012 at 4:08 PM, Joerg Sonnenberger <span dir="ltr"><<a href="mailto:joerg@britannica.bec.de" target="_blank">joerg@britannica.bec.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Thu, Aug 02, 2012 at 11:19:13AM -0000, Alexey Samsonov wrote:<br>
> Author: samsonov<br>
> Date: Thu Aug 2 06:19:13 2012<br>
> New Revision: 161168<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=161168&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=161168&view=rev</a><br>
> Log:<br>
> [Sanitizer] Workaround for a compiler warning - ISO C++ forbids casting pointer-to-function to pointer-to-object, so we use cast via integral type<br>
<br>
</div>Shouldn't this be using (u)intptr_t from stdint.h?<br></blockquote><div><br></div><div>Sometimes there is no stdint.h (like in Visual Studio 9).</div><div>Also, we try to contain inclusion of system headers in headers of ASan/TSan runtimes as much as possible.</div></div></blockquote><br></div><div><div class="gmail_quote">IIRC, doesn't 64-bit Windows (precisely one of the cases where you might be lacking stdint.h) use an ILP32 model? uintptr_t may not be perfect, but unsigned long doesn't seem right at all.</div><div class="gmail_quote"><br></div><div class="gmail_quote">- Steve</div></div></body></html>