<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><base href="x-msg://10346/"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">That looks much better. Go ahead and commit it.<div><br></div><div>--Owen</div><div><br><div><div>On Jul 17, 2012, at 3:46 PM, "Oliveira, Victor" <<a href="mailto:Victor.Oliveira@amd.com">Victor.Oliveira@amd.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div ocsi="0" fpstyle="1" style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; "><div style="direction: ltr; font-family: Tahoma; font-size: 10pt; ">ok, I think it's better now.<br><br>Victor<br><br><div style="font-family: 'Times New Roman'; font-size: 16px; "><hr tabindex="-1"><div id="divRpF360248" style="direction: ltr; "><font face="Tahoma" size="2"><b>From:</b><span class="Apple-converted-space"> </span>Owen Anderson [<a href="mailto:resistor@mac.com">resistor@mac.com</a>]<br><b>Sent:</b><span class="Apple-converted-space"> </span>Tuesday, July 17, 2012 12:31 PM<br><b>To:</b><span class="Apple-converted-space"> </span>Oliveira, Victor<br><b>Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><span class="Apple-converted-space"> </span>LLVM; Villmow, Micah; Bridgman, John<br><b>Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-commits] AMDIL backend first patches<br></font><br></div><div></div><div>Hi Victor,<div><br></div><div>I like the concept of your PassManager debugging patch, but I'd like to see it provide a little bit more useful output. As it is, only someone who has looked at this code is going to be able to tell what the output means. Perhaps add some annotations in the output and/or a useful error message when AnalysisPass2 is null. A good use case to keep in mind is "would this output be useful to an LLVM developer who hasn't looked at the logging code, and is trying to track down an error?"</div><div><br></div><div>--Owen</div><div><br></div><div><br><div><div>On Jul 13, 2012, at 1:37 PM, "Oliveira, Victor" <<a href="mailto:Victor.Oliveira@amd.com" target="_blank">Victor.Oliveira@amd.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; "><div style="direction: ltr; font-family: Tahoma; font-size: 10pt; ">Hi!<br><br>I'm Victor Oliveira and I'm an intern at AMD. I've been working last weeks to upstream the most we can of our AMDIL backend in LLVM.<br><br>These first two patches are changes that we have made in LLVM Core. They consist of a MachinePostDominator pass and a change in PassManager to have some diagnostic information for debugging incorrect pass setup.<br><br>As soon we finish our internal review process I'll send the remaining patches with the AMDIL backend.<br><br>Thanks a lot,<br>Victor Oliveira<br><br></div><span><0001-Including-a-MachinePostDominator-pass.patch></span><span><0002-Adding-some-debug-information-to-PassManager.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div></div></div><span><0002-Adding-some-debug-information-to-PassManager.patch></span></div></blockquote></div><br></div></div></body></html>