<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 13, 2012, at 11:41 AM, Chandler Carruth <<a href="mailto:chandlerc@gmail.com">chandlerc@gmail.com</a>> wrote:</div><blockquote type="cite"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap:break-word"><div><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div>The other option to just bailing in findKill is to store the Kills in LiveVariable as a DenseMap<MachineBasicBlock*, MachineInstr*>. I don't immediately see anything that would likely make this terrible. The case where there are *tons* of kills, is probably already the case where its worth the extra memory to get some performance.</div>
</div></div></blockquote><div><br></div></div><div>I think it is rare enough that you can simply bail if the kill list is too large.</div></div></blockquote><div><br></div><div>Yea, I don't even have a test case where it happens. I can add the code defensively if you're worried.</div></div></blockquote><div><br></div><div>No, don't bother.</div><br><blockquote type="cite"><div class="gmail_quote">
<div>Final patch attached. I've updated both of the Reschedule functions, and removed findLocalKills completely.</div></div></blockquote><div><br></div><div>LGTM, thanks!</div><div><br></div><div>/jakob</div><div><br></div></div></body></html>