<html><head></head><body bgcolor="#FFFFFF"><div>To ease the review process it's best to have small incremental patches. Please apply your patch now and include the test case once the assembler is in a more functional state.</div><div><br></div><div> Chad<br><br><br></div><div><br>On Jul 4, 2012, at 6:53 AM, "Medic, Vladimir" <<a href="mailto:vmedic@mips.com">vmedic@mips.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hi Chad,<br>
the test is prepared and I have attached it here for you to see. The problem is that it is a part of a larger patch that implements the llvm assembler for Mips and even with the current patch it will not be fixed. The idea was to split the large patch into
several smaller and to, as much as possible, split the patches into target dependent and independent parts. Now, I can either change the patches so this one would contain the test file and the necessary change in MipsAsmParser.cpp or hold this patch until
the target dependent patches are accepted and there is a functional assembler parser for Mips.<br>
<br>
Vladimir<br>
<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF297189"><font color="#000000" face="Tahoma" size="2"><b>From:</b> Chad Rosier [<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>]<br>
<b>Sent:</b> Tuesday, July 03, 2012 6:54 PM<br>
<b>To:</b> Medic, Vladimir<br>
<b>Cc:</b> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>; Jovanovic, Petar<br>
<b>Subject:</b> Re: [llvm-commits] Directive parsing for AsmParser patch<br>
</font><br>
</div>
<div></div>
<div>Vladimir,
<div>You should at lease add a test case that expressed the exact fix you're trying to make. This would ensure it doesn't regress in the future. Beyond that I don't have any great suggestions.</div>
<div><br>
</div>
<div> Chad</div>
<div><br>
<div>
<div>On Jun 29, 2012, at 8:19 AM, Medic, Vladimir wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><span class="Apple-style-span" style="border-collapse:separate; font-family:Helvetica; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:2; text-indent:0px; text-transform:none; white-space:normal; widows:2; word-spacing:0px; font-size:medium">
<div style="word-wrap:break-word">
<div style="direction:ltr; font-family:Tahoma; color:rgb(0,0,0); font-size:10pt">
<div style="direction:ltr; font-family:Tahoma; color:rgb(0,0,0); font-size:10pt">
Hi Chad,<br>
I have run the basic "make check-all" test suite ,LLVM SingleSource and MultiSource test suite. What sort of testing should be performed also to verify the change?<br>
<br>
Vladimir<br>
<div style="font-family:'Times New Roman'; color:rgb(0,0,0); font-size:16px">
<hr tabindex="-1">
<div id="divRpF229811" style="direction:ltr"><font color="#000000" face="Tahoma" size="2"><b>From:</b><span class="Apple-converted-space"> </span>Chad Rosier [<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>]<br>
<b>Sent:</b><span class="Apple-converted-space"> </span>Thursday, June 28, 2012 10:32 PM<br>
<b>To:</b><span class="Apple-converted-space"> </span>Medic, Vladimir<br>
<b>Cc:</b><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>; Jovanovic, Petar<br>
<b>Subject:</b><span class="Apple-converted-space"> </span>Re: [llvm-commits] Directive parsing for AsmParser patch<br>
</font><br>
</div>
<div></div>
<div>
<div>Vladimir,</div>
<div>Jim Grosbach commented that this seemed reasonable, but also suggested having a "copious" amount of testing. What kind of testing has been done? Please include test cases.</div>
<div><br>
</div>
<div> Chad</div>
<div>
<div><br>
<div>
<div>On Jun 28, 2012, at 8:21 AM, Medic, Vladimir wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite"><span class="Apple-style-span" style="border-collapse:separate; font-family:Helvetica; font-style:normal; font-variant:normal; font-weight:normal; letter-spacing:normal; line-height:normal; orphans:2; text-indent:0px; text-transform:none; white-space:normal; widows:2; word-spacing:0px; font-size:medium">
<div>
<div style="direction:ltr; font-family:Tahoma; color:rgb(0,0,0); font-size:10pt">
Hi everyone,<br>
did somebody had a chance to look at the patch provided? It is not a large change so I think it won't take much time to review it.<br>
<br>
Thanks<br>
<br>
Vladimir<br>
<div style="font-family:'Times New Roman'; color:rgb(0,0,0); font-size:16px">
<hr tabindex="-1">
<div id="divRpF738187" style="direction:ltr"><font color="#000000" face="Tahoma" size="2"><b>From:</b><span class="Apple-converted-space"> </span>Medic, Vladimir<br>
<b>Sent:</b><span class="Apple-converted-space"> </span>Tuesday, June 05, 2012 10:02 AM<br>
<b>To:</b><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b><span class="Apple-converted-space"> </span>Directive parsing for AsmParser patch<br>
</font><br>
</div>
<div></div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:rgb(0,0,0); font-size:10pt">
Hi all,<br>
please find attached a patch for AsmParser that enables target dependent directive parsing to hook before standard parser as discussed in:<br>
<a href="http://old.nabble.com/Directive-parsing-for-AsmParser-td33822227.html#a33822227" target="_blank">http://old.nabble.com/Directive-parsing-for-AsmParser-td33822227.html#a33822227</a><br>
<br>
Looking forward to your comments and suggestions.<br>
<br>
Vladimir Medic<br>
<br>
</div>
</div>
</div>
</div>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div>
</span></blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</span><br class="Apple-interchange-newline">
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div>
</div></blockquote><blockquote type="cite"><div><mips_directives.s></div></blockquote></body></html>