<div class="gmail_extra"><div class="gmail_quote">On Tue, Jul 3, 2012 at 1:19 PM, Anton Korobeynikov <span dir="ltr"><<a href="mailto:anton@korobeynikov.info" target="_blank" class="cremed">anton@korobeynikov.info</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Stepan,<br>
<div class="im"><br>
> +  void diff_single_numbers(self *LExclude, self *Intersection, self *RExclude,<br>
> +                               const self& RHS) {<br>
</div>Will you please consider reading<br>
<a href="http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly" target="_blank" class="cremed">http://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly</a><br>

?<br>
Or at least look for function names around?<br></blockquote><div><br></div><div>This is egregious.</div><div><br></div><div>Stepan, please revert, and please switch to pre-commit review until you're more comfortable with the coding standards of LLVM. This code isn't ready to be committed to trunk in its current form. </div>
</div></div>