<html><head><base href="x-msg://20023/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Vladimir,</div><div>Jim Grosbach commented that this seemed reasonable, but also suggested having a "copious" amount of testing. What kind of testing has been done? Please include test cases.</div><div><br></div><div> Chad</div><div><div><br><div><div>On Jun 28, 2012, at 8:21 AM, Medic, Vladimir wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div ocsi="0" fpstyle="1"><div style="direction: ltr; font-family: Tahoma; color: rgb(0, 0, 0); font-size: 10pt; ">Hi everyone,<br>did somebody had a chance to look at the patch provided? It is not a large change so I think it won't take much time to review it.<br><br>Thanks<br><br>Vladimir<br><div style="font-family: 'Times New Roman'; color: rgb(0, 0, 0); font-size: 16px; "><hr tabindex="-1"><div id="divRpF738187" style="direction: ltr; "><font color="#000000" face="Tahoma" size="2"><b>From:</b><span class="Apple-converted-space"> </span>Medic, Vladimir<br><b>Sent:</b><span class="Apple-converted-space"> </span>Tuesday, June 05, 2012 10:02 AM<br><b>To:</b><span class="Apple-converted-space"> </span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><b>Subject:</b><span class="Apple-converted-space"> </span>Directive parsing for AsmParser patch<br></font><br></div><div></div><div><div style="direction: ltr; font-family: Tahoma; color: rgb(0, 0, 0); font-size: 10pt; ">Hi all,<br>please find attached a patch for AsmParser that enables target dependent directive parsing to hook before standard parser as discussed in:<br><a href="http://old.nabble.com/Directive-parsing-for-AsmParser-td33822227.html#a33822227" target="_blank">http://old.nabble.com/Directive-parsing-for-AsmParser-td33822227.html#a33822227</a><br><br>Looking forward to your comments and suggestions.<br><br>Vladimir Medic<br> <br></div></div></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></span></blockquote></div><br></div></div></body></html>