Sorry, reverted in r158855.<br><br><div class="gmail_quote">On Wed, Jun 20, 2012 at 2:13 PM, Alexander Potapenko <span dir="ltr"><<a href="mailto:glider@google.com" target="_blank">glider@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">We're seeing the following reports on the AddressSanitizer Linux<br>
buildbot that builds LLVM:<br>
<br>
make[2]: Leaving directory<br>
`/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/tools/bugpoint-passes'<br>
/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/Release+Asserts/lib/libLLVMMipsDisassembler.a(MipsDisassembler.o):<br>
In function `DecodeCPURegsRegisterClass(llvm::MCInst&, unsigned int,<br>
unsigned long, void const*)':<br>
MipsDisassembler.cpp:(.text+0x4ab): undefined reference to<br>
`llvm::Mips::CPURegsRegClass'<br>
/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/Release+Asserts/lib/libLLVMMipsDisassembler.a(MipsDisassembler.o):<br>
In function `DecodeFGR32RegisterClass(llvm::MCInst&, unsigned int,<br>
unsigned long, void const*)':<br>
MipsDisassembler.cpp:(.text+0x55b): undefined reference to<br>
`llvm::Mips::FGR32RegClass'<br>
/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/Release+Asserts/lib/libLLVMMipsDisassembler.a(MipsDisassembler.o):<br>
In function `DecodeFGR64RegisterClass(llvm::MCInst&, unsigned int,<br>
unsigned long, void const*)':<br>
MipsDisassembler.cpp:(.text+0x60b): undefined reference to<br>
`llvm::Mips::FGR64RegClass'<br>
/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/Release+Asserts/lib/libLLVMMipsDisassembler.a(MipsDisassembler.o):<br>
In function `DecodeCPU64RegsRegisterClass(llvm::MCInst&, unsigned int,<br>
unsigned long, void const*)':<br>
MipsDisassembler.cpp:(.text+0x6bb): undefined reference to<br>
`llvm::Mips::CPU64RegsRegClass'<br>
/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/Release+Asserts/lib/libLLVMMipsDisassembler.a(MipsDisassembler.o):<br>
In function `DecodeAFGR64RegisterClass(llvm::MCInst&, unsigned int,<br>
unsigned long, void const*)':<br>
MipsDisassembler.cpp:(.text+0x773): undefined reference to<br>
`llvm::Mips::AFGR64RegClass'<br>
/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/Release+Asserts/lib/libLLVMMipsDisassembler.a(MipsDisassembler.o):<br>
In function `DecodeFMem(llvm::MCInst&, unsigned int, unsigned long,<br>
void const*)':<br>
MipsDisassembler.cpp:(.text+0x821): undefined reference to<br>
`llvm::Mips::FGR64RegClass'<br>
MipsDisassembler.cpp:(.text+0x8a9): undefined reference to<br>
`llvm::Mips::CPURegsRegClass'<br>
/usr/local/google/home/asanbot/b2/slave/linux/build/llvm-build/Release+Asserts/lib/libLLVMMipsDisassembler.a(MipsDisassembler.o):<br>
In function `DecodeMem(llvm::MCInst&, unsigned int, unsigned long,<br>
void const*)':<br>
MipsDisassembler.cpp:(.text+0xa43): undefined reference to<br>
`llvm::Mips::CPURegsRegClass'<br>
MipsDisassembler.cpp:(.text+0xc23): undefined reference to<br>
`llvm::Mips::CPURegsRegClass'<br>
<br>
Could these be related to your change?<br>
<div class="HOEnZb"><div class="h5"><br>
On Thu, Jun 21, 2012 at 12:42 AM, Akira Hatanaka <<a href="mailto:ahatanak@gmail.com">ahatanak@gmail.com</a>> wrote:<br>
> r158846.<br>
><br>
> On Wed, Jun 6, 2012 at 1:42 AM, Medic, Vladimir <<a href="mailto:vmedic@mips.com">vmedic@mips.com</a>> wrote:<br>
>><br>
>><br>
>> Hi everyone,<br>
>> as suggested by Jacob I have changed the patch to use tableGen generated<br>
>> register tables. Please find the new patch attached. Looking forward to your<br>
>> comments.<br>
>><br>
>> Vladimir<br>
>> ________________________________<br>
>> From: Jakob Stoklund Olesen [<a href="mailto:stoklund@2pi.dk">stoklund@2pi.dk</a>]<br>
>> Sent: Thursday, May 31, 2012 6:28 PM<br>
>> To: Medic, Vladimir<br>
>> Cc: <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>; Jovanovic, Petar<br>
>> Subject: Re: [llvm-commits] Move register tables from MipsDisassembler<br>
>><br>
>><br>
>> On May 31, 2012, at 8:10 AM, "Medic, Vladimir" <<a href="mailto:vmedic@mips.com">vmedic@mips.com</a>> wrote:<br>
>><br>
>> He everyone,<br>
>> please find attached the patch that moves register definitions from<br>
>> MipsDisassembler.cpp into a new header file. This is done so the tables can<br>
>> be used from other modules.<br>
>><br>
>><br>
>> Hi Vladimir,<br>
>><br>
>> Can't you use the register class tables generated by TableGen instead?<br>
>> They should be available through MCRegisterInfo.<br>
>><br>
>> /jakob<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888">--<br>
Alexander Potapenko<br>
Software Engineer<br>
Google Moscow<br>
</font></span></blockquote></div><br>