<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle">P {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
P {
MARGIN-TOP: 0px; MARGIN-BOTTOM: 0px
}
</style>
</head>
<body fPStyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">
<p>Ping, now that people should be recovered from that big conference last week.</p>
<p>--paulr</p>
<p> </p>
<div style="FONT-FAMILY: Times New Roman; COLOR: #000000; FONT-SIZE: 16px">
<hr tabindex="-1">
<div style="DIRECTION: ltr" id="divRpF345895"><font color="#000000" size="2" face="Tahoma"><b>From:</b> llvm-commits-bounces@cs.uiuc.edu [llvm-commits-bounces@cs.uiuc.edu] on behalf of Robinson, Paul [Paul.Robinson@am.sony.com]<br>
<b>Sent:</b> Thursday, June 07, 2012 2:13 PM<br>
<b>To:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> [llvm-commits] [PATCH] PR9493, Fix for DW_AT_location<br>
</font><br>
</div>
<div></div>
<div>
<div style="FONT-FAMILY: Tahoma; DIRECTION: ltr; COLOR: #000000; FONT-SIZE: 10pt">
<p>Ping, with improved subject line.</p>
<p>--paulr</p>
<p> </p>
<div style="FONT-FAMILY: Times New Roman; COLOR: #000000; FONT-SIZE: 16px">
<div style="DIRECTION: ltr" id="divRpF367893"> </div>
<div></div>
<div>
<div style="FONT-FAMILY: Tahoma; DIRECTION: ltr; COLOR: #000000; FONT-SIZE: 10pt">
<p>My first patch attempt, here goes!</p>
<p> </p>
<p>Fix for bug 9493. On non-Darwin platforms, references from DW_AT_location to the .debug_loc section need to be relocatable. This patch improves on r127757, which didn't do the right thing for Darwin (and was reverted pretty quickly).</p>
<p> </p>
<p>The original bug showed up on ARM, but because of the Darwin/non-Darwin difference I revised the test to target x86_64, where it was easy to try both cases. Also there isn't an ARM subdirectory under test/DebugInfo and I didn't want to get too ambitious
on my first try. The problem isn't really architecture-specific but it would be easy to create an ARM equivalent for the non-Darwin version of the test, if anybody thought that was useful.</p>
<p> </p>
<p>One question, I did not change the name of doesDwarfUseLabelOffsetForRanges() or its underlying data member DwarfUsesLabelOffsetForRanges. These used to apply only to the DW_AT_ranges attribute, but now they apply to DW_AT_location as well. Change the names,
or not? It seemed excessive to add a second function/flag because these DWARF attributes will always want to be handled the same way. If renaming is better, maybe DwarfUsesRelocationsAcrossSections would be more accurate.<br>
</p>
<p>Thanks,</p>
<p>Paul Robinson</p>
<p> </p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>