<div>Sometimes the # works, but not always. It works earlier in the document. The remaining 80 char column violations are due to Sphinx not accepting section titles to be broken across lines.</div><div><br></div>I figured you'd gone home for the day and submitted my patch - too early once again. I'll move the FAQ to the User Guides section and then resubmit. The other things should be okay already.<div>
<br></div><div>Here's an idea for Google (Google, google it!): Make Google+ so that it displays the users on a world map and displays the current time of the user, if you hover your cursor over somebody on the map. I live and work in Denmark so I am probably off everybody else by a factor of 6 to 9 hours, which sometimes makes me react impatiently because I don't feel like waiting until the next working day in the US. And then convince everybody to drop Facebook and use Google+ instead ;-) <br>
<br><div class="gmail_quote">2012/6/16 Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I don't know what's happening with the "#." stuff. The sphinx reST primer even gives that as an example, so maybe it is something in the LLVM sphinx configuration.<div><br></div><div>I would hold off on putting the FAQ at the top of the index. That change can be made later if there is a perceived need.</div>
<div class="im">
<div><br></div><div>> <span style="font-size:13px;font-family:arial,sans-serif">The C backend change never made it into the reST file because it was a manually written TOC entry without any text block.</span></div>
</div><div><span style="font-size:13px;font-family:arial,sans-serif">Good to see that you are on top of this :)</span></div><div><span style="font-size:13px;font-family:arial,sans-serif"><br>
</span></div><div><span style="font-size:13px;font-family:arial,sans-serif">Other than some 80-column violations this LGTM.</span></div><div><span style="font-size:13px;font-family:arial,sans-serif"><br>
</span></div><div><span style="font-size:13px;font-family:arial,sans-serif">For the final patch, you should probably include the following three things:</span></div><div><span style="font-size:13px;font-family:arial,sans-serif">1. add the FAQ.rst file that we've been looking at here</span></div>
<div><span style="font-size:13px;font-family:arial,sans-serif">2. remove the FAQ.html file</span></div><div><span style="font-size:13px;font-family:arial,sans-serif">3. link this file into a toctree (to avoid Sphinx warnings)</span></div>
<span class="HOEnZb"><font color="#888888">
<div><br></div></font></span><div><span class="HOEnZb"><font color="#888888">--Sean Silva</font></span><div><div class="h5"><br><br><div class="gmail_quote">On Fri, Jun 15, 2012 at 2:50 PM, Mikael Lyngvig <span dir="ltr"><<a href="mailto:mikael@lyngvig.org" target="_blank">mikael@lyngvig.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>The numbered lists are driving me crazy! No matter what I try, they end up being numbered 1, 1, 1, and not 1, 2, 3. Do you have any experience with this? The embedded bulletted list shows up properly. I use #. because I prefer that to 1. I could number the list manually, but that kind of defeats the whole purpose of using Sphinx (IMHO). This is about the numbered list in the "I'd like to write a self-hosting compiler..." section.</div>
<div><br></div><div>I'll munge about and try not to create havoc (sometimes I feel like an elephant in a glass retail store).</div><div><br></div><div>The C backend change never made it into the reST file because it was a manually written TOC entry without any text block.</div>
<div><div>
<div><br></div><div><br><div class="gmail_quote">2012/6/15 Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><font face="arial, sans-serif">Hi Mikael,</font></div><div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif">It seems like the ugly underlining that Michael mentioned is actually a CSS problem and not a document structure problem. </font><span style="font-family:arial,sans-serif">Michael Spencer and I are working on updating the CSS to avoid it.</span></div>
<div><span style="font-family:arial,sans-serif"><br></span></div><div><span style="font-family:arial,sans-serif">Also, you should prepare this as a patch that creates the reST file and removes the FAQ.html file and links the reST FAQ into the main toctree somehow, in order to avoid the conflict between FAQ.html and the generated FAQ.rst -> FAQ.html.</span></div>
<div><span style="font-family:arial,sans-serif"><br></span></div><div><span style="font-family:arial,sans-serif">btw, there was a recent change I caught out of the corner of my eye to the FAQ removing references to the C backend. Could you doublecheck to make sure that those changes get pulled into your reST version? Thanks.</span></div>
<div><span style="font-family:arial,sans-serif"><br></span></div><div><span style="font-family:arial,sans-serif">--Sean Silva</span></div><br><div class="gmail_quote"><div>On Fri, Jun 15, 2012 at 1:46 PM, Mikael Lyngvig <span dir="ltr"><<a href="mailto:mikael@lyngvig.org" target="_blank">mikael@lyngvig.org</a>></span> wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>I don't seem to be able to make it fit in 80 chars. For instance, the numbered lists require more than 80 chars and Sphinx won't accept them if they are broken into multiple lines. The same goes for the questions: Several Sphinx commands must fit within a line for Sphinx to accept them. I've tried backquoting the end-of-line character (text text text \), but that didn't work either.<div>
<br></div><div>It all looked very nice in my end, but I didn't use the LLVM configuration of Sphinx as I don't know where to get it from.<br><div><br></div><div>I got some pointers to the SVN repository for the FAQ, but the first didn't include the FAQ and the second gave me a cycle while trying an SVN pull. What URL do you use to pull out the documentation for LLVM?</div>
<div>
<div><br><div class="gmail_quote">2012/6/15 Michael Spencer <span dir="ltr"><<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>On Fri, Jun 15, 2012 at 2:25 AM, Mikael Lyngvig <<a href="mailto:mikael@lyngvig.org" target="_blank">mikael@lyngvig.org</a>> wrote:<br>
> Can't really make a patch file as it is a new file based on FAQ.html from<br>
> the website.<br>
><br>
> Changes are:<br>
><br>
> 1. The format is now reST instead of HTML.<br>
> 2. A few (like two or three) missing code markups have been added.<br>
> 3. Sphinx code-blocks are now used for all kinds of code: bash, c, and<br>
> llvm.<br>
><br>
> Other than that, the file should be a faithful and precise conversion from<br>
> HTML to reST.<br>
><br>
><br>
> Cheers,<br>
> Mikael<br>
<br>
</div></div>It needs to be 80-col except for underlined headers. Also it needs to<br>
be linked from a toctree and properly integrated. It also currently<br>
conflicts with the FAQ.html that gets copied in so I had to rename it<br>
to even see what it looked like.<br>
<br>
Each header is currently getting underlined by Sphinx, this looks<br>
pretty weird. It should be using a different header level.<br>
<span><font color="#888888"><br>
- Michael Spencer<br>
</font></span></blockquote></div><br></div></div></div>
<br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br></div>